From b0380eab63d6bf0572fbdd18acf2821f44a8b196 Mon Sep 17 00:00:00 2001
From: kqmaverick <121722567+kqmaverick@users.noreply.github.com>
Date: Wed, 28 Jun 2023 22:38:31 -0700
Subject: [PATCH] fix(authelia): redirection URL require https (#10026)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
Force https:// for redirection URL and update setup guide to reflect.

⚒️ Fixes  #

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**

**📃 Notes:**
Please verify I did this correctly.

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [X] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/enterprise/authelia/Chart.yaml         |  2 +-
 .../enterprise/authelia/docs/Setup-Guide.md   |  5 ++--
 charts/enterprise/authelia/docs/validation.md | 23 +++++++++++++++++++
 charts/enterprise/authelia/questions.yaml     |  1 +
 4 files changed, 27 insertions(+), 4 deletions(-)
 create mode 100644 charts/enterprise/authelia/docs/validation.md

diff --git a/charts/enterprise/authelia/Chart.yaml b/charts/enterprise/authelia/Chart.yaml
index 4137965e3ff..6d85c431a73 100644
--- a/charts/enterprise/authelia/Chart.yaml
+++ b/charts/enterprise/authelia/Chart.yaml
@@ -35,7 +35,7 @@ sources:
   - https://github.com/authelia/chartrepo
   - https://github.com/authelia/authelia
 type: application
-version: 15.1.29
+version: 15.1.30
 annotations:
   truecharts.org/catagories: |
     - security
diff --git a/charts/enterprise/authelia/docs/Setup-Guide.md b/charts/enterprise/authelia/docs/Setup-Guide.md
index c9bd097d5c3..fa4c8b6d053 100644
--- a/charts/enterprise/authelia/docs/Setup-Guide.md
+++ b/charts/enterprise/authelia/docs/Setup-Guide.md
@@ -30,9 +30,8 @@ LLDAP is a `Stable` train chart and therefore isn't supported at the same level
 
 ### App Configuration
 
-Domain: `mydomain.com` <- Your domain without https://
-Default Redirection URL: `auth.mydomain.com`
-  - Can be anything, but we'll stick to auth.mydomain.com. As well, this will be the ingress URL for `Authelia`
+- Domain: `mydomain.com` <- Your domain without https://
+- Default Redirection URL: `https://auth.mydomain.com` <- Can be anything, but we'll stick to auth.mydomain.com. As well, this will be the ingress URL for `Authelia`
 
 ### LDAP Backend Configuration
 
diff --git a/charts/enterprise/authelia/docs/validation.md b/charts/enterprise/authelia/docs/validation.md
new file mode 100644
index 00000000000..d630cfe9c17
--- /dev/null
+++ b/charts/enterprise/authelia/docs/validation.md
@@ -0,0 +1,23 @@
+# Input Validation
+
+**`Default Redirection URL`**
+
+Accepts:
+
+- `https://`
+- DNS host
+- Characters (`0-9`, `a-z`, `A-Z`, `-`, `.`)
+
+Accepted formats are:
+
+- `https://dnshost`
+- `https://DNSHOST`
+- `https://DNS-HOST`
+- `https://dns-host`
+
+Regex used to match this: `^https?:\/\/(.*)`
+You can try live [here](https://regex101.com/r/zFt9zy/1)
+
+---
+
+_If you find a field that you think it needs validation, please open an issue on github_
diff --git a/charts/enterprise/authelia/questions.yaml b/charts/enterprise/authelia/questions.yaml
index 4f5e5609b6c..ce13acb4760 100644
--- a/charts/enterprise/authelia/questions.yaml
+++ b/charts/enterprise/authelia/questions.yaml
@@ -28,6 +28,7 @@ questions:
     schema:
       type: string
       default: ""
+      valid_chars: '^https?:\/\/(.*)'
   - variable: theme
     group: "App Configuration"
     label: "Theme"