use TCP probe by default and add docs for probetype (#594)

* use TCP probe by default and add docs for probetype

* small fixup

charts/library/common/Chart.yaml

@@ -18,4 +18,4 @@ maintainers:
 name: common
 sources:
 type: library
-version: 6.3.7
+version: 6.3.8

charts/library/common/templates/lib/controller/_probes.tpl

@@ -7,7 +7,7 @@ Probes selection logic.
 {{- if $primaryService -}}
   {{- $primaryPort = get $primaryService.ports (include "common.classes.service.ports.primary" (dict "serviceName" (include "common.service.primary" .) "values" $primaryService)) -}}
 {{- end -}}
-{{- $probeType := "HTTP" -}}
+{{- $probeType := "TCP" -}}
 
 {{- range $probeName, $probe := .Values.probes }}
   {{- if $probe.enabled -}}
@@ -18,10 +18,10 @@ Probes selection logic.
     {{- else }}
       {{- if and $primaryService $primaryPort -}}
           {{- if $probe.type -}}
-          {{- $probeType = $probe.type -}}
+            {{- if eq $probe.type "AUTO" -}}
-        {{- else -}}
-          {{- if $primaryPort.protocol -}}
               {{- $probeType = $primaryPort.protocol -}}
+            {{- else -}}
+              {{- $probeType := $probe.type -}}
             {{- end }}
           {{- end }}
 

charts/library/common/values.yaml

@@ -153,6 +153,9 @@ probes:
     enabled: true
     # -- Set this to `true` if you wish to specify your own livenessProbe
     custom: false
+    # -- sets the probe type when not using a custom probe
+    # @default -- "TCP"
+    type: TCP
     # -- If a HTTP probe is used (default for HTTP/HTTPS services) this path is used
     # @default -- "/"
     path: "/"
@@ -172,6 +175,9 @@ probes:
     enabled: true
     # -- Set this to `true` if you wish to specify your own readinessProbe
     custom: false
+    # -- sets the probe type when not using a custom probe
+    # @default -- "TCP"
+    type: TCP
     # -- If a HTTP probe is used (default for HTTP/HTTPS services) this path is used
     # @default -- "/"
     path: "/"
@@ -191,6 +197,9 @@ probes:
     enabled: true
     # -- Set this to `true` if you wish to specify your own startupProbe
     custom: false
+    # -- sets the probe type when not using a custom probe
+    # @default -- "TCP"
+    type: TCP
     # -- If a HTTP probe is used (default for HTTP/HTTPS services) this path is used
     # @default -- "/"
     path: "/"