(feat) Standardise and Harden default app securitycontext (#1028)

* Apply security hardened defaults to values.yaml for all apps

* Add default common securityContext to all apps

* Adjust securityContext defaults in questions.yaml, according to values.yaml

* Add default common podSecurityContext to all apps

* Clean whitespace

* Clean more whitespace

* Adjust podSecurityContext defaults in questions.yaml, according to values.yaml

* fix pgadmin

Co-authored-by: Stavros kois <s.kois@outlook.com>

charts/stable/pretend-youre-xyzzy/Chart.yaml

@@ -1,9 +1,9 @@
 apiVersion: v2
-appVersion: "4"
+appVersion: '4'
 dependencies:
 - name: common
   repository: https://truecharts.org
-  version: 7.0.14
+  version: 8.0.7
 description: pretend-youre-xyzzy, a cards against humanity clone
 home: https://github.com/truechartsapps/tree/master/charts/incubator/pretend-youre-xyzzy
 icon: https://apk-google.com/wp-content/uploads/2020/12/Client-for-Pretend-Youre-Xyzzy-open-source-5.0.1.png
@@ -21,4 +21,4 @@ name: pretend-youre-xyzzy
 sources:
 - https://github.com/ajanata/PretendYoureXyzzy
 - https://github.com/emcniece/DockerYourXyzzy
-version: 2.0.2
+version: 3.0.0

charts/stable/pretend-youre-xyzzy/SCALE/questions.yaml

@@ -86,8 +86,6 @@ questions:
             default: "002"
 # Include{containerConfig}
 
-
-
   - variable: service
     group: "Networking and Services"
     label: "Configure Service(s)"
@@ -424,8 +422,6 @@ questions:
                                   schema:
                                     type: string
 
-
-
 # Include{ingressList}
 
   - variable: securityContext
@@ -448,7 +444,7 @@ questions:
           label: "Allow Privilege Escalation"
           schema:
             type: boolean
-            default: true
+            default: false
         - variable: runAsNonRoot
           label: "runAsNonRoot"
           schema:
@@ -478,7 +474,7 @@ questions:
           description: "The group that should own ALL storage."
           schema:
             type: int
-            default: 0
+            default: 568
         - variable: supplementalGroups
           label: "supplemental Groups"
           schema:
@@ -540,7 +536,6 @@ questions:
                   default: "50Mi"
                   valid_chars: '^([0-9.]+)([EPTGMK]i?|[EPTGMK]?|e[0-9]+)$'
 
-
   - variable: autoscaling
     group: "Resources and Devices"
     label: "(Advanced) Horizontal Pod Autoscaler"

charts/stable/pretend-youre-xyzzy/values.yaml

@@ -14,17 +14,12 @@ image:
   pullPolicy: IfNotPresent
 
 securityContext:
-  privileged: false
   readOnlyRootFilesystem: false
-  allowPrivilegeEscalation: true
   runAsNonRoot: false
 
 podSecurityContext:
   runAsUser: 0
   runAsGroup: 0
-  fsGroup: 0
-  supplementalGroups: []
-  fsGroupChangePolicy: "OnRootMismatch"
 
 # -- Configures service settings for the chart.
 # @default -- See values.yaml