(feat) Standardise and Harden default app securitycontext (#1028)

* Apply security hardened defaults to values.yaml for all apps

* Add default common securityContext to all apps

* Adjust securityContext defaults in questions.yaml, according to values.yaml

* Add default common podSecurityContext to all apps

* Clean whitespace

* Clean more whitespace

* Adjust podSecurityContext defaults in questions.yaml, according to values.yaml

* fix pgadmin

Co-authored-by: Stavros kois <s.kois@outlook.com>

charts/stable/pihole/Chart.yaml

@@ -1,9 +1,9 @@
 apiVersion: v2
-appVersion: "2021.09"
+appVersion: '2021.09'
 dependencies:
 - name: common
-  repository: https://truecharts.org/
-  version: 7.0.14
+  repository: https://truecharts.org
+  version: 8.0.7
 deprecated: false
 description: DNS and Ad-filtering for your network
 home: https://github.com/truecharts/apps/tree/master/charts/stable/pihole
@@ -21,4 +21,4 @@ sources:
 - https://github.com/pi-hole
 - https://github.com/pi-hole/docker-pi-hole
 type: application
-version: 2.0.6
+version: 3.0.0

charts/stable/pihole/SCALE/questions.yaml

@@ -123,9 +123,6 @@ questions:
             type: string
             default: "149.112.112.112"
 
-
-
-
   - variable: service
     group: "Networking and Services"
     label: "Configure Service(s)"
@@ -956,9 +953,6 @@ questions:
                                   schema:
                                     type: string
 
-
-
-
 # Include{ingressList}
 
   - variable: securityContext
@@ -981,13 +975,58 @@ questions:
           label: "Allow Privilege Escalation"
           schema:
             type: boolean
-            default: true
+            default: false
         - variable: runAsNonRoot
           label: "runAsNonRoot"
           schema:
             type: boolean
             default: false
 
+  - variable: podSecurityContext
+    group: "Security and Permissions"
+    label: "Pod Security Context"
+    schema:
+      type: dict
+      attrs:
+        - variable: runAsUser
+          label: "runAsUser"
+          description: "The UserID of the user running the application"
+          schema:
+            type: int
+            default: 0
+        - variable: runAsGroup
+          label: "runAsGroup"
+          description: The groupID this App of the user running the application"
+          schema:
+            type: int
+            default: 0
+        - variable: fsGroup
+          label: "fsGroup"
+          description: "The group that should own ALL storage."
+          schema:
+            type: int
+            default: 568
+        - variable: supplementalGroups
+          label: "supplemental Groups"
+          schema:
+            type: list
+            default: []
+            items:
+              - variable: supplementalGroupsEntry
+                label: "supplemental Group"
+                schema:
+                  type: int
+        - variable: fsGroupChangePolicy
+          label: "When should we take ownership?"
+          schema:
+            type: string
+            default: "OnRootMismatch"
+            enum:
+              - value: "OnRootMismatch"
+                description: "OnRootMismatch"
+              - value: "Always"
+                description: "Always"
+
   - variable: resources
     group: "Resources and Devices"
     label: "Resource Limits"
@@ -1029,7 +1068,6 @@ questions:
                   default: "50Mi"
                   valid_chars: '^([0-9.]+)([EPTGMK]i?|[EPTGMK]?|e[0-9]+)$'
 
-
   - variable: autoscaling
     group: "Resources and Devices"
     label: "(Advanced) Horizontal Pod Autoscaler"

charts/stable/pihole/values.yaml

@@ -5,6 +5,14 @@ image:
   pullPolicy: IfNotPresent
   tag: v2021.09@sha256:e043ab188da4c36abb11d70d82bbfb394ef5054abff21dafbaf54bc21861bd1e
 
+securityContext:
+  readOnlyRootFilesystem: false
+  runAsNonRoot: false
+
+podSecurityContext:
+  runAsUser: 0
+  runAsGroup: 0
+
 envFrom:
   - configMapRef:
       name: pihole-env
@@ -33,7 +41,6 @@ pihole:
   DNS1: "9.9.9.9"
   DNS2: "149.112.112.112"
 
-
 persistence:
   config:
     enabled: true