(feat) Standardise and Harden default app securitycontext (#1028)

* Apply security hardened defaults to values.yaml for all apps

* Add default common securityContext to all apps

* Adjust securityContext defaults in questions.yaml, according to values.yaml

* Add default common podSecurityContext to all apps

* Clean whitespace

* Clean more whitespace

* Adjust podSecurityContext defaults in questions.yaml, according to values.yaml

* fix pgadmin

Co-authored-by: Stavros kois <s.kois@outlook.com>

charts/stable/openldap/Chart.yaml

@@ -1,9 +1,9 @@
 apiVersion: v2
-appVersion: "1.5.0"
+appVersion: 1.5.0
 dependencies:
 - name: common
-  repository: https://truecharts.org/
-  version: 7.0.14
+  repository: https://truecharts.org
+  version: 8.0.7
 deprecated: false
 description: Community developed LDAP software
 home: https://www.openldap.org
@@ -26,4 +26,4 @@ sources:
 - https://github.com/jp-gouin/helm-openldap
 - https://github.com/osixia/docker-openldap
 type: application
-version: 2.0.2
+version: 3.0.0

charts/stable/openldap/SCALE/ix_values.yaml

@@ -43,6 +43,10 @@ replication:
   starttls: "critical"
   tls_reqcert: "never"
 
+persistence:
+  varrun:
+    enabled: false
+
 
 ##
 # Most other defaults are set in questions.yaml

charts/stable/openldap/SCALE/questions.yaml

@@ -206,8 +206,6 @@ questions:
 
 # Include{containerConfig}
 
-
-
   - variable: service
     group: "Networking and Services"
     label: "Configure Service(s)"
@@ -409,7 +407,6 @@ questions:
                               max: 65535
                               default: 36100
 
-
   - variable: serviceexpert
     group: "Networking and Services"
     label: "Show Expert Config"
@@ -724,12 +721,57 @@ questions:
           label: "Allow Privilege Escalation"
           schema:
             type: boolean
-            default: true
+            default: false
         - variable: runAsNonRoot
           label: "runAsNonRoot"
           schema:
             type: boolean
             default: false
+
+  - variable: podSecurityContext
+    group: "Security and Permissions"
+    label: "Pod Security Context"
+    schema:
+      type: dict
+      attrs:
+        - variable: runAsUser
+          label: "runAsUser"
+          description: "The UserID of the user running the application"
+          schema:
+            type: int
+            default: 0
+        - variable: runAsGroup
+          label: "runAsGroup"
+          description: The groupID this App of the user running the application"
+          schema:
+            type: int
+            default: 0
+        - variable: fsGroup
+          label: "fsGroup"
+          description: "The group that should own ALL storage."
+          schema:
+            type: int
+            default: 568
+        - variable: supplementalGroups
+          label: "supplemental Groups"
+          schema:
+            type: list
+            default: []
+            items:
+              - variable: supplementalGroupsEntry
+                label: "supplemental Group"
+                schema:
+                  type: int
+        - variable: fsGroupChangePolicy
+          label: "When should we take ownership?"
+          schema:
+            type: string
+            default: "OnRootMismatch"
+            enum:
+              - value: "OnRootMismatch"
+                description: "OnRootMismatch"
+              - value: "Always"
+                description: "Always"
   - variable: resources
     group: "Resources and Devices"
     label: ""
@@ -771,7 +813,6 @@ questions:
                   default: "50Mi"
                   valid_chars: '^([0-9.]+)([EPTGMK]i?|[EPTGMK]?|e[0-9]+)$'
 
-
   - variable: autoscaling
     group: "Resources and Devices"
     label: "(Advanced) Horizontal Pod Autoscaler"

charts/stable/openldap/values.yaml

@@ -5,6 +5,14 @@ image:
   pullPolicy: IfNotPresent
   tag: v1.5.0@sha256:fd870eecad0a5a5097ec7377a4441aa77171b4e10d8336f63698144dc3a51a4b
 
+securityContext:
+  readOnlyRootFilesystem: false
+  runAsNonRoot: false
+
+podSecurityContext:
+  runAsUser: 0
+  runAsGroup: 0
+
 controller:
   # -- Set the controller type.
   # Valid options are deployment, daemonset or statefulset
@@ -26,6 +34,10 @@ controller:
   # -- ReplicaSet revision history limit
   revisionHistoryLimit: 3
 
+persistence:
+  varrun:
+    enabled: false
+
 service:
   main:
     ports: