From aa62d4242e4e26e1e9e8e0570d55af7a7ff89f7f Mon Sep 17 00:00:00 2001 From: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com> Date: Mon, 8 Apr 2024 07:35:16 +0200 Subject: [PATCH] fix(whisper-asr-webservice): liveness probe fix, add large-v3 model, update version, remove unused storage (#20042) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** - Update of the container images, as they were outdated (v1.2.3 -> v1.3.0) - Change of the `liveness probe` from `http`-> `tcp`. Because now the pod is killed during transcoding/translating operations due to the unresponsiveness of the http interface during this time. - add whisper `large-v3` model as option - removing `/root/.cache/faster_whisper` storage values/questions as there is no use for it as all models are stored in `/root/.cache/whisper` - Some minor description fixes ⚒️ Fixes # **⚙️ Type of change** - [X] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** For reference about the "pod gets killed issue" with whisper-asr-webservice if `liveness probe` is set to `http` https://discord.com/channels/830763548678291466/1184211864700338186 **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning - [X] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):` or `chore(chart-name):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com> --- charts/stable/whisper-asr-webservice/Chart.yaml | 2 +- charts/stable/whisper-asr-webservice/questions.yaml | 12 +++--------- charts/stable/whisper-asr-webservice/values.yaml | 10 +++------- 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/charts/stable/whisper-asr-webservice/Chart.yaml b/charts/stable/whisper-asr-webservice/Chart.yaml index b3d5cab7fd1..7c1c3067804 100644 --- a/charts/stable/whisper-asr-webservice/Chart.yaml +++ b/charts/stable/whisper-asr-webservice/Chart.yaml @@ -7,7 +7,7 @@ annotations: truecharts.org/min_helm_version: "3.11" truecharts.org/train: stable apiVersion: v2 -appVersion: 1.2.3 +appVersion: 1.3.0 dependencies: - name: common version: 20.3.2 diff --git a/charts/stable/whisper-asr-webservice/questions.yaml b/charts/stable/whisper-asr-webservice/questions.yaml index c9d08d5032d..a4b0d2e9e0b 100644 --- a/charts/stable/whisper-asr-webservice/questions.yaml +++ b/charts/stable/whisper-asr-webservice/questions.yaml @@ -41,11 +41,13 @@ questions: - value: medium description: Medium - value: large - description: Large + description: Large (only OpenAI Whisper) - value: large-v1 description: Large V1 - value: large-v2 description: Large V2 + - value: large-v3 + description: Large V3 - variable: ASR_ENGINE label: ASR Engine schema: @@ -105,14 +107,6 @@ questions: additional_attrs: true type: dict attrs: -# Include{persistenceBasic} - - variable: faster-whisper - label: "App Faster Whisper Storage" - description: "Stores the Application Faster Whisper." - schema: - additional_attrs: true - type: dict - attrs: # Include{persistenceBasic} # Include{persistenceList} # Include{ingressRoot} diff --git a/charts/stable/whisper-asr-webservice/values.yaml b/charts/stable/whisper-asr-webservice/values.yaml index ce8255a13eb..f65dbca530e 100644 --- a/charts/stable/whisper-asr-webservice/values.yaml +++ b/charts/stable/whisper-asr-webservice/values.yaml @@ -1,11 +1,11 @@ image: repository: onerahmet/openai-whisper-asr-webservice pullPolicy: IfNotPresent - tag: "v1.2.3@sha256:a94b6bbbea73578896112dee36d9b71783b8b4696c4eedc2ae75eb129ca24339\r" + tag: "v1.3.0@sha256:9332d6faf787ce42886f5e220f3cea801d8530251991192c470847e9efb1239e\r" gpuImage: repository: onerahmet/openai-whisper-asr-webservice pullPolicy: IfNotPresent - tag: "v1.2.3-gpu@sha256:0e78dd19e44589ed84eaf928ff7e0754476fa8692fd6856d58dea903efb80354\r" + tag: "v1.3.0-gpu@sha256:61a54aca45045aa04e31c27ef098890ab196696cc15c55875fb9f0c6ed804456\r" securityContext: container: readOnlyRootFilesystem: false @@ -20,8 +20,7 @@ workload: imageSelector: image probes: liveness: - type: http - path: "/docs" + type: tcp readiness: type: http path: "/docs" @@ -48,9 +47,6 @@ persistence: whisper: enabled: true mountPath: "/root/.cache/whisper" - faster-whisper: - enabled: true - mountPath: "/root/.cache/faster_whisper" portal: open: enabled: true