From a848bbb51d21504f7fa08606bd9cd681ee6b9079 Mon Sep 17 00:00:00 2001 From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Date: Mon, 3 Jul 2023 16:11:28 -0400 Subject: [PATCH] fix(ghostfolio) remove unused storage option and clean up values.yaml (#10083) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** removed a storage option and clean up the values.yaml ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [X] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/incubator/ghostfolio/Chart.yaml | 2 +- charts/incubator/ghostfolio/questions.yaml | 2 -- charts/incubator/ghostfolio/values.yaml | 29 +++++++++++----------- 3 files changed, 15 insertions(+), 18 deletions(-) diff --git a/charts/incubator/ghostfolio/Chart.yaml b/charts/incubator/ghostfolio/Chart.yaml index 355c3e7c569..5d9a117bef8 100644 --- a/charts/incubator/ghostfolio/Chart.yaml +++ b/charts/incubator/ghostfolio/Chart.yaml @@ -25,7 +25,7 @@ sources: - https://github.com/ghostfolio/ghostfolio - https://ghostfol.io/ type: application -version: 0.0.3 +version: 0.0.4 annotations: truecharts.org/catagories: | - finance diff --git a/charts/incubator/ghostfolio/questions.yaml b/charts/incubator/ghostfolio/questions.yaml index d3e7e89d954..cd6121105cc 100644 --- a/charts/incubator/ghostfolio/questions.yaml +++ b/charts/incubator/ghostfolio/questions.yaml @@ -48,8 +48,6 @@ questions: # Include{serviceExpertRoot} # Include{serviceExpert} # Include{serviceList} -# Include{persistenceRoot} -# Include{persistenceBasic} # Include{persistenceList} # Include{ingressRoot} - variable: main diff --git a/charts/incubator/ghostfolio/values.yaml b/charts/incubator/ghostfolio/values.yaml index d26af7e57ad..f33772250aa 100644 --- a/charts/incubator/ghostfolio/values.yaml +++ b/charts/incubator/ghostfolio/values.yaml @@ -3,6 +3,20 @@ image: pullPolicy: IfNotPresent tag: v1.283.5@sha256:06a3ff744e4571695bf3185710c7addfa74a0318f4d6d53d3e7da7df6ade4516 +securityContext: + container: + runAsNonRoot: false + readOnlyRootFilesystem: false + runAsUser: 0 + runAsGroup: 0 + +service: + main: + ports: + main: + port: 3333 + targetPort: 3333 + workload: main: podSpec: @@ -44,13 +58,6 @@ workload: key: redis-password REDIS_PORT: "6379" -service: - main: - ports: - main: - port: 3333 - targetPort: 3333 - cnpg: main: enabled: true @@ -60,14 +67,6 @@ cnpg: redis: enabled: true -securityContext: - container: - runAsNonRoot: false - readOnlyRootFilesystem: false - runAsUser: 0 - runAsGroup: 0 - fsGroup: 568 - portal: open: enabled: true