From 9aec4e5062b37ed7623cab7ebba8173c7d5f86c1 Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Wed, 26 Jul 2023 22:13:28 -0400 Subject: [PATCH] migrate(ipmi-tools): Migrate to New Common (#10880) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Co-authored-by: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> --- charts/incubator/ipmi-tools/Chart.yaml | 6 +-- charts/incubator/ipmi-tools/questions.yaml | 54 +++++++++---------- .../incubator/ipmi-tools/templates/NOTES.txt | 1 + .../ipmi-tools/templates/common.yaml | 2 +- charts/incubator/ipmi-tools/values.yaml | 35 ++++++------ 5 files changed, 51 insertions(+), 47 deletions(-) create mode 100644 charts/incubator/ipmi-tools/templates/NOTES.txt diff --git a/charts/incubator/ipmi-tools/Chart.yaml b/charts/incubator/ipmi-tools/Chart.yaml index 093d1184139..5b58da582f4 100644 --- a/charts/incubator/ipmi-tools/Chart.yaml +++ b/charts/incubator/ipmi-tools/Chart.yaml @@ -9,9 +9,9 @@ appVersion: "latest" dependencies: - name: common repository: https://library-charts.truecharts.org - version: 11.1.2 + version: 13.2.1 deprecated: false -description: This is a Chart with a webGUI to manage a Dell servers fan speeds using IPMI. You must enable IPMI from iDRAC. You can pass credentials through environment variables or enter them in the webGUI at runtime. +description: A simple WebGUI Fan controller for IPMI. home: https://truecharts.org/charts/incubator/ipmi-tools icon: https://truecharts.org/img/hotlink-ok/chart-icons/ipmi-tools.png keywords: @@ -29,4 +29,4 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/incubator/ipmi-tools - https://github.com/EdwardChamberlain/IPMI-Fan-Controller type: application -version: 2.0.9 +version: 3.0.0 diff --git a/charts/incubator/ipmi-tools/questions.yaml b/charts/incubator/ipmi-tools/questions.yaml index 20858d7f965..b54d1406b79 100644 --- a/charts/incubator/ipmi-tools/questions.yaml +++ b/charts/incubator/ipmi-tools/questions.yaml @@ -13,31 +13,31 @@ questions: # Include{containerBasic} # Include{containerAdvanced} - - variable: env - group: "App Configuration" - label: "Image Environment" - schema: - additional_attrs: true - type: dict - attrs: - - variable: APP_IPMI_HOST - label: "APP_IPMI_HOST" - description: "The IP or host of your iDRAC interface." - schema: - type: string - default: "" - - variable: APP_IPMI_USER - label: "APP_IPMI_USER" - description: "Your IPMI username (same as your iDRAC user)" - schema: - type: string - default: "" - - variable: APP_IPMI_PASS - label: "APP_IPMI_PASS" - description: "Your IPMI password (same as your iDRAC password)" - schema: - type: string - default: "" + - variable: env + group: "App Configuration" + label: "Image Environment" + schema: + additional_attrs: true + type: dict + attrs: + - variable: APP_IPMI_HOST + label: "App IPMI Host" + description: "The IP or host of your iDRAC interface." + schema: + type: string + default: "" + - variable: APP_IPMI_USER + label: "App IPMI User" + description: "Your IPMI username (same as your iDRAC user)" + schema: + type: string + default: "" + - variable: APP_IPMI_PASS + label: "App IPMI Pass" + description: "Your IPMI password (same as your iDRAC password)" + schema: + type: string + default: "" # Include{containerConfig} # Include{serviceRoot} - variable: main @@ -94,13 +94,13 @@ questions: description: "The UserID of the user running the application" schema: type: int - default: 0 + default: 568 - variable: runAsGroup label: "runAsGroup" description: "The groupID of the user running the application" schema: type: int - default: 0 + default: 568 # Include{securityContextContainer} # Include{securityContextAdvanced} # Include{securityContextPod} diff --git a/charts/incubator/ipmi-tools/templates/NOTES.txt b/charts/incubator/ipmi-tools/templates/NOTES.txt new file mode 100644 index 00000000000..efcb74cb772 --- /dev/null +++ b/charts/incubator/ipmi-tools/templates/NOTES.txt @@ -0,0 +1 @@ +{{- include "tc.v1.common.lib.chart.notes" $ -}} diff --git a/charts/incubator/ipmi-tools/templates/common.yaml b/charts/incubator/ipmi-tools/templates/common.yaml index cbf66c20818..78d963fb168 100644 --- a/charts/incubator/ipmi-tools/templates/common.yaml +++ b/charts/incubator/ipmi-tools/templates/common.yaml @@ -1,2 +1,2 @@ {{/* Render the templates */}} -{{ include "tc.common.loader.all" . }} +{{ include "tc.v1.common.loader.all" . }} diff --git a/charts/incubator/ipmi-tools/values.yaml b/charts/incubator/ipmi-tools/values.yaml index 3d496dafe6a..a7855a6e07b 100644 --- a/charts/incubator/ipmi-tools/values.yaml +++ b/charts/incubator/ipmi-tools/values.yaml @@ -1,28 +1,31 @@ -env: - APP_IPMI_HOST: "" - APP_IPMI_PASS: "" - APP_IPMI_USER: "" image: pullPolicy: IfNotPresent repository: tccr.io/truecharts/ipmi-tools tag: latest@sha256:705e2d6a0787c6da56dd4d8b7ed79ac2f76f64eb129f0c707078a1fb4879d17d -persistence: - data: - enabled: true - mountPath: /data -podSecurityContext: - runAsGroup: 0 - runAsUser: 0 -securityContext: - readOnlyRootFilesystem: false - runAsNonRoot: false + +workload: + main: + podSpec: + containers: + main: + env: + APP_IPMI_HOST: "" + APP_IPMI_PASS: "" + APP_IPMI_USER: "" + service: main: ports: main: port: 4017 - protocol: TCP + protocol: http targetPort: 80 +persistence: + data: + enabled: true + mountPath: /data + portal: - enabled: true + open: + enabled: true