From 956d118e2f060e711ece03370acbf6908417dec7 Mon Sep 17 00:00:00 2001 From: astro-stan <36302090+astro-stan@users.noreply.github.com> Date: Sat, 18 Apr 2026 22:38:24 +0100 Subject: [PATCH] fix(multus-cni): Remove unsupported -o pipefail option from sh scripts (#47210) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Not sure how this wasn't a problem before but I recently upgraded the chart ot a more recent version and started getting: ``` sh: 1: set: Illegal option -o pipefail ``` pipefail is not supprted by `sh`, so it needs to be removed. ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [x] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code - [ ] 📜 Documentation Changes **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made changes to the documentation - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning - [X] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or `fix(docs):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: astro-stan <36302090+astro-stan@users.noreply.github.com> --- charts/stable/multus-cni/Chart.yaml | 2 +- charts/stable/multus-cni/values.yaml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/stable/multus-cni/Chart.yaml b/charts/stable/multus-cni/Chart.yaml index 9aa990ded87..3175a5044a1 100644 --- a/charts/stable/multus-cni/Chart.yaml +++ b/charts/stable/multus-cni/Chart.yaml @@ -39,5 +39,5 @@ sources: - https://github.com/trueforge-org/truecharts/tree/master/charts/stable/multus-cni - https://hub.docker.com/r/alpine/crane type: application -version: 2.0.4 +version: 2.0.5 diff --git a/charts/stable/multus-cni/values.yaml b/charts/stable/multus-cni/values.yaml index fbbd8b640cd..e6cc18069a4 100644 --- a/charts/stable/multus-cni/values.yaml +++ b/charts/stable/multus-cni/values.yaml @@ -260,7 +260,7 @@ workload: - sh - -c - | - set -euo pipefail + set -eu cd /tmp echo "Pulling '{{ .Values.talosCniImage.repository }}:{{ .Values.talosCniImage.tag }}' image..." @@ -328,7 +328,7 @@ workload: eval "$@" } - set -euo pipefail + set -eu echo "Cleaning up Multus CNI config..." echoRun rm -rf "{{ tpl .Values.persistence.cniconf.mountPath $ }}"/*multus.* @@ -424,7 +424,7 @@ workload: - sh - -c - | - set -euo pipefail + set -eu SOCKET_PATH="{{ tpl .Values.persistence.hostrun.mountPath $ }}/cni/dhcp.sock" CNI_BIN_DIR="{{ (tpl .Values.persistence.cnibin.mountPath $) }}"