From 914158ee2be31e2acd1c4bca71403c5a3e16d8f6 Mon Sep 17 00:00:00 2001 From: sdimovv <36302090+sdimovv@users.noreply.github.com> Date: Sat, 2 Dec 2023 13:20:42 +0000 Subject: [PATCH] fix(recyclarr): Add missing chart config options (#15295) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes # Adds some missing chart config options, such as the ability to set arbitrary environment variables. Useful when you want Recyclarr to read credentials from the container env (https://recyclarr.dev/wiki/yaml/env-vars/) Also adds the ability to add custom ingress - in case the user wants to deploy a codeserver addon to manage the config. **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** Deployed on native helm and tested the `CRON_SCHEDULE` env is present with correct value. I am hoping the questions.yaml is also correct. I copied it from other charts. **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [X] ⚠️ My changes generate no new warnings - [X] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> --- charts/stable/recyclarr/Chart.yaml | 3 ++- charts/stable/recyclarr/questions.yaml | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/charts/stable/recyclarr/Chart.yaml b/charts/stable/recyclarr/Chart.yaml index ae53d035bf6..80a949bb029 100644 --- a/charts/stable/recyclarr/Chart.yaml +++ b/charts/stable/recyclarr/Chart.yaml @@ -1,7 +1,7 @@ kubeVersion: '>=1.24.0' apiVersion: v2 name: recyclarr -version: 6.0.17 +version: 6.0.18 appVersion: 6.0.2 description: A command-line application that will automatically synchronize recommended settings from TRaSH guides to your Sonarr/Radarr instances. @@ -13,6 +13,7 @@ sources: - https://github.com/recyclarr/recyclarr/pkgs/container/recyclarr - https://github.com/truecharts/charts/tree/master/charts/stable/recyclarr - https://ghcr.io/recyclarr/recyclarr +type: application maintainers: - name: TrueCharts email: info@truecharts.org diff --git a/charts/stable/recyclarr/questions.yaml b/charts/stable/recyclarr/questions.yaml index cfd3239fef0..c98ea244e9d 100644 --- a/charts/stable/recyclarr/questions.yaml +++ b/charts/stable/recyclarr/questions.yaml @@ -23,6 +23,9 @@ questions: schema: type: string default: "@daily" +# Include{containerBasic} +# Include{containerAdvanced} +# Include{containerConfig} # Include{podOptions} # Include{serviceExpertRoot} # Include{serviceExpert}