From 907925b95e9e272144f77a8608baf2b94327f924 Mon Sep 17 00:00:00 2001
From: Boemeltrein <130394941+Boemeltrein@users.noreply.github.com>
Date: Tue, 10 Jun 2025 20:22:54 +0200
Subject: [PATCH] fix(minecraft-router): probes (#36191)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->
Get rid of a lot of enoying POD Logs:
For example:
` level=error msg="Failed to read packet"
clientAddr="192.168.1.181:48812" error=EOF`

Set probes as official helm chart:

https://github.com/itzg/minecraft-server-charts/blob/4c9a8dafc84f7a76dbad1838af7cef51151470c5/charts/mc-router/templates/deployment.yaml#L125

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code
- [ ] 📜 Documentation Changes

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
On own cluster:

https://github.com/Boemeltrein/TalosCluster/commit/bf94e20ecd4a1cbc3f399576febdc93ca27af45c

https://github.com/Boemeltrein/TalosCluster/commit/4bc5ff3a98e86472880b46743f1974b7fd468fa3

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made changes to the documentation
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
- [x] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or
`fix(docs):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/stable/minecraft-router/Chart.yaml  |  2 +-
 charts/stable/minecraft-router/values.yaml | 18 ++++++++++++------
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/charts/stable/minecraft-router/Chart.yaml b/charts/stable/minecraft-router/Chart.yaml
index b2e87e7ae14..9a35fa5b085 100644
--- a/charts/stable/minecraft-router/Chart.yaml
+++ b/charts/stable/minecraft-router/Chart.yaml
@@ -37,5 +37,5 @@ sources:
   - https://github.com/truecharts/charts/tree/master/charts/stable/minecraft-router
   - https://hub.docker.com/r/itzg/mc-router
 type: application
-version: 1.10.0
+version: 1.10.1
 
diff --git a/charts/stable/minecraft-router/values.yaml b/charts/stable/minecraft-router/values.yaml
index 2167bb38f4f..422dcc32b43 100644
--- a/charts/stable/minecraft-router/values.yaml
+++ b/charts/stable/minecraft-router/values.yaml
@@ -27,14 +27,20 @@ workload:
         main:
           probes:
             liveness:
-              enabled: true
-              type: tcp
+              port: "{{ .Values.service.api.ports.api.port }}"
+              path: /routes
+              httpHeaders:
+                Accept: application/json
             readiness:
-              enabled: true
-              type: tcp
+              port: "{{ .Values.service.api.ports.api.port }}"
+              path: /routes
+              httpHeaders:
+                Accept: application/json
             startup:
-              enabled: true
-              type: tcp
+              port: "{{ .Values.service.api.ports.api.port }}"
+              path: /routes
+              httpHeaders:
+                Accept: application/json
           env:
             API_BINDING: ":{{ .Values.service.api.ports.api.port }}"
             PORT: "{{ .Values.service.main.ports.main.port }}"