fix(incubator): some cleanup (#3586)

* fix(arksurvival): cleanup

* cleanup

* update questions

* chore(incubator): some cleanup

* remove enabled true from main services

* bump all incubator

* lint

* empty lines

* emtpy line

charts/incubator/memories-of-mars/Chart.yaml

@@ -26,4 +26,4 @@ sources:
   - https://memoriesofmars.com/
   - https://hub.docker.com/r/ich777/steamcmd/
 type: application
-version: 0.0.17
+version: 0.0.19

charts/incubator/memories-of-mars/questions.yaml

@@ -12,6 +12,26 @@ questions:
 # Include{recreate}
 # Include{controllerExpert}
 # Include{controllerExpertExtraArgs}
+  - variable: secretEnv
+    group: "Container Configuration"
+    label: "Image Secrets"
+    schema:
+      additional_attrs: true
+      type: dict
+      attrs:
+        - variable: USERNAME
+          label: "USERNAME"
+          description: "Your Steam username goes here if you want to install a game that needs a valid account, otherwise leave it blank (ATTENTION You have to disable Steam Guard)."
+          schema:
+            type: string
+            default: ""
+        - variable: PASSWRD
+          label: "PASSWRD"
+          description: "Your Steam password goes here if you want to install a game that needs a valid account, otherwise leave it blank (ATTENTION You have to disable Steam Guard)."
+          schema:
+            type: string
+            private: true
+            default: ""
   - variable: env
     group: "Container Configuration"
     label: "Image Environment"
@@ -20,41 +40,29 @@ questions:
       type: dict
       attrs:
         - variable: GAME_ID
-          label: 'GAME_ID'
-          description: "The GAMEID that the container download at startup.(httpsdeveloper.valvesoftware.comwikiDedicatedServersList)"
+          label: "GAME_ID"
+          description: "The GAME_ID that the container download at startup.(https://developer.valvesoftware.com/wiki/Dedicated_Servers_List)"
           schema:
             type: string
             default: "897590"
         - variable: GAME_PARAMS
-          label: 'GAME_PARAMS'
+          label: "GAME_PARAMS"
           description: "Enter Extra Startup Parameters here if needed, otherwise leave empty (eg -port=7778, -maxplayers=12)"
           schema:
             type: string
             default: ""
         - variable: MULTIHOME
-          label: 'MULTIHOME'
+          label: "MULTIHOME"
           description: "This has to be the IP of your TrueNAS server otherwise you cant connect to the game and the game will lost connection to the server!"
           schema:
             type: string
             default: ""
-        - variable: USERNAME
-          label: 'USERNAME'
-          description: "Your Steam username goes here if you want to install a game that needs a valid account, otherwise leave it blank (ATTENTION You have to disable Steam Guard)."
-          schema:
-            type: string
-            default: ""
         - variable: VALIDATE
-          label: 'VALIDATE'
+          label: "VALIDATE"
           description: "Set the Variable to true if you want to validate the installation otherwise leave it blank."
           schema:
-            type: string
-            default: ""
-        - variable: PASSWRD
-          label: 'PASSWRD'
-          description: "Your Steam password goes here if you want to install a game that needs a valid account, otherwise leave it blank (ATTENTION You have to disable Steam Guard)."
-          schema:
-            type: string
-            default: ""
+            type: boolean
+            default: true
 # Include{containerConfig}
 # Include{serviceRoot}
         - variable: main

charts/incubator/memories-of-mars/values.yaml

@@ -1,24 +1,26 @@
-env:
-  GAME_ID: "897590"
-  GAME_PARAMS: ""
-  MULTIHOME: ""
-  PASSWRD: ""
-  USERNAME: ""
-  VALIDATE: ""
 image:
   pullPolicy: IfNotPresent
   repository: tccr.io/truecharts/memories-of-mars
   tag: latest@sha256:d8e166dd8b52383615ae1ab01129aabd3c90ebe8b450d8b0c31b675e533ba15a
-persistence:
-  serverfiles:
-    enabled: true
-    mountPath: /serverdata/serverfiles
-  steamcmd:
-    enabled: true
-    mountPath: /serverdata/steamcmd
+
 podSecurityContext:
   runAsGroup: 0
   runAsUser: 0
+
+securityContext:
+  readOnlyRootFilesystem: false
+  runAsNonRoot: false
+
+secretEnv:
+  USERNAME: ""
+  PASSWRD: ""
+
+env:
+  GAME_ID: "897590"
+  GAME_PARAMS: ""
+  MULTIHOME: ""
+  VALIDATE: false
+
 probes:
   liveness:
     enabled: false
@@ -26,10 +28,14 @@ probes:
     enabled: false
   startup:
     enabled: false
-securityContext:
-  readOnlyRootFilesystem: false
-  runAsNonRoot: false
+
 service:
+  main:
+    ports:
+      main:
+        port: 7777
+        protocol: UDP
+        targetPort: 7777
   beaconport:
     enabled: true
     ports:
@@ -38,14 +44,14 @@ service:
         port: 15000
         protocol: UDP
         targetPort: 15000
-  main:
+
+persistence:
+  serverfiles:
     enabled: true
-    ports:
-      main:
-        enabled: true
-        port: 7777
-        protocol: UDP
-        targetPort: 7777
+    mountPath: /serverdata/serverfiles
+  steamcmd:
+    enabled: true
+    mountPath: /serverdata/steamcmd
 
 portal:
   enabled: true