fix(thunderbird): cleanup (#3372)

* fix(thunderbird): cleanup

* tcp probe

* update image

* root

charts/incubator/thunderbird/Chart.yaml

@@ -1,8 +1,3 @@
-annotations:
-  truecharts.org/SCALE-support: "true"
-  truecharts.org/catagories: |
-    - Productivity
-    - Tools-Utilities
 apiVersion: v2
 appVersion: "latest"
 dependencies:
@@ -10,15 +5,12 @@ dependencies:
     repository: https://library-charts.truecharts.org
     version: 10.4.8
 deprecated: false
-description:
+description: "This container will download and install Thunderbird in the preferred version and language."
-  "This container will download and install Thunderbird in the preferred\
-  \ version and language.\r\n"
 home: https://github.com/truecharts/charts/tree/master/charts/incubator/thunderbird
 icon: https://truecharts.org/img/chart-icons/thunderbird.png
 keywords:
   - thunderbird
-  - Productivity
+  - mail
-  - Tools-Utilities
 kubeVersion: ">=1.16.0-0"
 maintainers:
   - email: info@truecharts.org
@@ -29,4 +21,9 @@ sources:
   - https://www.thunderbird.net/
   - https://hub.docker.com/r/ich777/thunderbird/
 type: application
-version: 0.0.14
+version: 0.0.15
+annotations:
+  truecharts.org/SCALE-support: "true"
+  truecharts.org/catagories: |
+    - productivity
+    - mail

charts/incubator/thunderbird/questions.yaml

@@ -7,6 +7,7 @@ portals:
       - "$kubernetes-resource_configmap_portal_host"
     ports:
       - "$kubernetes-resource_configmap_portal_port"
+    path: "/vnc.html?autoconnect=true"
 questions:
   - variable: portal
     group: "Container Image"
@@ -24,7 +25,6 @@ questions:
             type: boolean
             default: true
 # Include{global}
-
   - variable: controller
     group: "Controller"
     label: ""
@@ -75,7 +75,6 @@ questions:
                     - value: "OnDelete"
                       description: "(Legacy) OnDelete: ignore .spec.template changes"
 # Include{controllerExpert}
-
   - variable: env
     group: "Container Configuration"
     label: "Image Environment"
@@ -83,46 +82,37 @@ questions:
       additional_attrs: true
       type: dict
       attrs:
-
         - variable: THUNDERBIRD_V
-          label: 'THUNDERBIRD_V'
+          label: "THUNDERBIRD_V"
-          description: "Enter your preferred version or latest (without quotes) to grab the latest version."
+          description: "Enter your preferred version or latest to grab the latest version."
           schema:
             type: string
             default: "latest"
         - variable: THUNDERBIRD_LANG
-          label: 'THUNDERBIRD_LANG'
+          label: "THUNDERBIRD_LANG"
-          description: "Enter your preferred language here (eg en-US, de, fr, enUK,... you can get a full list here httpsarchive.mozilla.orgpubthunderbirdreleaseslatestREADME.txt)"
+          description: "Enter your preferred language here (eg en-US, you can get a full list here https://archive.mozilla.org/pub/thunderbird/releases/latest/README.txt)"
           schema:
             type: string
             default: "en-US"
         - variable: CUSTOM_RES_W
-          label: 'CUSTOM_RES_W'
+          label: "CUSTOM_RES_W"
-          description: "Minimum screen width 1000 pixels"
+          description: "Enter your preferred screen width"
           schema:
-            type: string
+            type: int
-            default: "1280"
+            default: 1280
         - variable: CUSTOM_RES_H
-          label: 'CUSTOM_RES_H'
+          label: "CUSTOM_RES_H"
-          description: "Minimum screen hight 880 pixels"
+          description: "Enter your preferred screen height"
           schema:
-            type: string
+            type: int
-            default: "768"
+            default: 768
-        - variable: EXTRA_PARAMETERS
+        - variable: DATA_PERM
-          label: 'EXTRA_PARAMETERS'
+          label: "DATA_PERM"
-          description: "If needed enter extra startup parameters here otherwise leave empty."
+          description: "Data permissions for /thunderbird folder"
           schema:
-            type: string
+            type: int
-            default: ""
+            default: 770
-        - variable: UMASK
-          label: 'UMASK'
-          description: "Container Variable UMASK"
-          schema:
-            type: string
-            default: "000"
-
 # Include{containerConfig}
-
   - variable: service
     group: "Networking and Services"
     label: "Configure Service(s)"
@@ -149,7 +139,7 @@ questions:
                             description: "This port exposes the container port on the service"
                             schema:
                               type: int
-                              default: 8080
+                              default: 10291
                               required: true
                           - variable: advanced
                             label: "Show Advanced settings"
@@ -162,7 +152,7 @@ questions:
                                   label: "Port Type"
                                   schema:
                                     type: string
-                                    default: TCP
+                                    default: "TCP"
                                     enum:
                                       - value: HTTP
                                         description: "HTTP"
@@ -185,9 +175,6 @@ questions:
                                   schema:
                                     type: int
                                     default: 8080
-
-
-
   - variable: serviceexpert
     group: "Networking and Services"
     label: "Show Expert Config"
@@ -202,11 +189,8 @@ questions:
           schema:
             type: boolean
             default: false
-
 # Include{serviceExpert}
-
 # Include{serviceList}
-
   - variable: persistence
     label: "Integrated Persistent Storage"
     description: "Integrated Persistent Storage"
@@ -215,21 +199,16 @@ questions:
       additional_attrs: true
       type: dict
       attrs:
-
+        - variable: data
-        - variable: datadir
+          label: "App Data Storage"
-          label: "datadir Storage"
+          description: "Stores the Application Data."
-          description: "Data Path"
           schema:
             additional_attrs: true
             type: dict
             attrs:
 # Include{persistenceBasic}
 # Include{persistenceAdvanced}
-
-
 # Include{persistenceList}
-
-
   - variable: ingress
     label: ""
     group: "Ingress"
@@ -244,17 +223,11 @@ questions:
             type: dict
             attrs:
 # Include{ingressDefault}
-
 # Include{ingressTLS}
-
 # Include{ingressTraefik}
-
 # Include{ingressExpert}
-
 # Include{ingressList}
-
 # Include{security}
-
   - variable: advancedSecurity
     label: "Show Advanced Security Settings"
     group: "Security and Permissions"
@@ -290,7 +263,6 @@ questions:
                   type: boolean
                   default: false
 # Include{securityContextAdvanced}
-
   - variable: podSecurityContext
     group: "Security and Permissions"
     label: "Pod Security Context"
@@ -306,7 +278,7 @@ questions:
             default: 0
         - variable: runAsGroup
           label: "runAsGroup"
-          description: The groupID this App of the user running the application"
+          description: "The groupID this App of the user running the application"
           schema:
             type: int
             default: 0
@@ -317,10 +289,6 @@ questions:
             type: int
             default: 568
 # Include{podSecurityContextAdvanced}
-
-
 # Include{resources}
-
 # Include{advanced}
-
 # Include{addons}

charts/incubator/thunderbird/values.yaml

@@ -1,30 +1,31 @@
-env:
-  CUSTOM_RES_H: "768"
-  CUSTOM_RES_W: "1280"
-  EXTRA_PARAMETERS: ""
-  THUNDERBIRD_LANG: en-US
-  THUNDERBIRD_V: latest@sha256:f0065aa44fb1c38b7fc30d34e220138dc0a0c6477b78eb7f59015622c2052030
-  UMASK: "000"
 image:
   pullPolicy: IfNotPresent
   repository: tccr.io/truecharts/thunderbird
-  tag: latest@sha256:0fb7ddd662ad23a22bba8fa13dcef2071da68b476c2a75805397c947bf787e04
+  tag: latest@sha256:5b26180ab2ccc8f42777404aa4765d0dae3be92b3cebc0ecb5dafc48ec825113
-persistence:
+
-  datadir:
-    enabled: true
-    mountPath: /thunderbird
 podSecurityContext:
   runAsGroup: 0
   runAsUser: 0
+
 securityContext:
   readOnlyRootFilesystem: false
   runAsNonRoot: false
+
+env:
+  THUNDERBIRD_V: "latest"
+  CUSTOM_RES_H: 768
+  CUSTOM_RES_W: 1280
+  DATA_PERM: 770
+  THUNDERBIRD_LANG: "en-US"
+
 service:
   main:
-    enabled: true
     ports:
       main:
-        enabled: true
+        port: 10291
-        port: 8080
-        protocol: TCP
         targetPort: 8080
+
+persistence:
+  data:
+    enabled: true
+    mountPath: /thunderbird

cspell.config.yaml

@@ -4,6 +4,7 @@ words:
   - allowtransparency
   - APITOKEN
   - appname
+  - autoconnect
   - backupname
   - bazarr
   - bugfixer's