From 8f923815b5c182f44c4e806a42574a03881bd256 Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Tue, 7 Nov 2023 05:17:49 -0500 Subject: [PATCH] feat(external-dns): Add CF_API_TOKEN support (#14414) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Missed the ENV_VAR for CF_API_TOKEN ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/incubator/external-dns/Chart.yaml | 2 +- charts/incubator/external-dns/questions.yaml | 6 ++++++ charts/incubator/external-dns/values.yaml | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/charts/incubator/external-dns/Chart.yaml b/charts/incubator/external-dns/Chart.yaml index 73cfaa2ae87..c97e7016810 100644 --- a/charts/incubator/external-dns/Chart.yaml +++ b/charts/incubator/external-dns/Chart.yaml @@ -22,7 +22,7 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/incubator/external-dns - https://github.com/kubernetes-sigs/external-dns type: application -version: 0.0.4 +version: 0.0.5 annotations: truecharts.org/category: networking truecharts.org/SCALE-support: "true" diff --git a/charts/incubator/external-dns/questions.yaml b/charts/incubator/external-dns/questions.yaml index 740c96d8dfd..df28f978b90 100644 --- a/charts/incubator/external-dns/questions.yaml +++ b/charts/incubator/external-dns/questions.yaml @@ -15,6 +15,12 @@ questions: additional_attrs: true type: dict attrs: + - variable: CF_API_TOKEN + label: Cloudflare API Token (preferred) + description: Cloudflare API Token, optimal when using with Cloudflare + schema: + type: string + default: "" - variable: CF_API_KEY label: Cloudflare API Key description: Cloudflare API Key if not using the preferred API Token diff --git a/charts/incubator/external-dns/values.yaml b/charts/incubator/external-dns/values.yaml index 75672e2a108..8233c2ac6d4 100644 --- a/charts/incubator/external-dns/values.yaml +++ b/charts/incubator/external-dns/values.yaml @@ -44,6 +44,7 @@ workload: startup: path: "/healthz" env: + CF_API_TOKEN: "" CF_API_KEY: "" CF_API_EMAIL: "" DO_TOKEN: ""