From 8d50330e39b932010425d8edcdaa993b536a2b87 Mon Sep 17 00:00:00 2001
From: Yiannis Marangos <psyberbits@gmail.com>
Date: Fri, 5 Jan 2024 00:55:58 +0200
Subject: [PATCH] fix(rdesktop): Mark port and probes as TCP (#16873)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
Fixes liveness probe of rdesktop. Port 3389 is RDP protocol, not HTTP.

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

I don't have a way to test it.

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 .github/ct-install.yaml            | 2 --
 charts/stable/rdesktop/Chart.yaml  | 2 +-
 charts/stable/rdesktop/values.yaml | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/.github/ct-install.yaml b/.github/ct-install.yaml
index ed38a7f1bf3..03fff04bbe4 100644
--- a/.github/ct-install.yaml
+++ b/.github/ct-install.yaml
@@ -148,7 +148,6 @@ excluded-charts:
   - charts/stable/plex-meta-manager
   - charts/stable/pod-gateway
   - charts/stable/promcord
-  - charts/stable/rdesktop
   - charts/stable/reg
   - charts/stable/romm
   - charts/stable/ser2sock
@@ -173,7 +172,6 @@ excluded-charts:
   - charts/stable/plex-meta-manager
   - charts/stable/pod-gateway
   - charts/stable/promcord
-  - charts/stable/rdesktop
   - charts/stable/reg
   - charts/stable/romm
   - charts/stable/ser2sock
diff --git a/charts/stable/rdesktop/Chart.yaml b/charts/stable/rdesktop/Chart.yaml
index c73140aa685..4e3dea0df4d 100644
--- a/charts/stable/rdesktop/Chart.yaml
+++ b/charts/stable/rdesktop/Chart.yaml
@@ -1,7 +1,7 @@
 kubeVersion: ">=1.24.0-0"
 apiVersion: v2
 name: rdesktop
-version: 7.1.22
+version: 7.1.23
 appVersion: latest
 description: Full desktop environments in many popular flavors for Alpine, Ubuntu, Arch, and Fedora accessible via RDP.
 home: https://truecharts.org/charts/stable/rdesktop
diff --git a/charts/stable/rdesktop/values.yaml b/charts/stable/rdesktop/values.yaml
index 98ba36525fa..f2154d50d0e 100644
--- a/charts/stable/rdesktop/values.yaml
+++ b/charts/stable/rdesktop/values.yaml
@@ -105,7 +105,7 @@ service:
     ports:
       main:
         port: 3389
-        protocol: http
+        protocol: tcp
         targetPort: 3389
 persistence:
   config: