From 8d1292060688ff6701896c92f472988942a48853 Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Sun, 15 Feb 2026 11:53:08 +0100 Subject: [PATCH] Ensure chart install tests wait for DaemonSet readiness (#44985) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Install tests were reporting success even when DaemonSet pods stayed in `PodInitializing`, so CI could pass without validating runtime readiness. The root issue was that chart-testing installs used only a timeout and did not instruct Helm to wait for resources to become ready. - **Install-test behavior** - Updated chart-testing Helm args in `.github/ct-install.yaml` to enforce readiness waiting during `ct install`. - This makes install tests fail when workloads (including DaemonSets) do not reach ready state within timeout. - **Config change** ```yaml # .github/ct-install.yaml - helm-extra-args: --timeout 250s + helm-extra-args: --wait --wait-for-jobs --timeout 250s ``` - **Impact** - CI install checks now validate actual deployment readiness rather than only successful resource creation. --- ✨ Let Copilot coding agent [set things up for you](https://github.com/trueforge-org/truecharts/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com> --- .github/ct-install.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ct-install.yaml b/.github/ct-install.yaml index 5676351de5f..727cfe55e98 100644 --- a/.github/ct-install.yaml +++ b/.github/ct-install.yaml @@ -1,6 +1,6 @@ remote: origin target-branch: master -helm-extra-args: --timeout 250s +helm-extra-args: --wait --wait-for-jobs --timeout 250s chart-yaml-schema: .github/chart_schema.yaml chart-dirs: - charts/incubator