From 84c79ab38db0a9996e22c13be8945600e23d16aa Mon Sep 17 00:00:00 2001 From: Codec <37117573+Jet132@users.noreply.github.com> Date: Wed, 20 Dec 2023 15:18:44 +0100 Subject: [PATCH] fix(etesync): respect config changes after initial deploy (#15080) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Fixes an issue where configuration changes in the UI (or for that matter anywhere from outside the container) don't get applied. Solution was to set the [undocumented](https://github.com/victor-rds/docker-etebase/blob/a590669c3558137ff7e7ee881b0870dab964dae4/context/entrypoint.sh#L298C54-L298C63) `REGEN_INI` flag to `true` to regenerate the `.ini` file on every startup. **โš™๏ธ Type of change** - [ ] โš™๏ธ Feature/App addition - [x] ๐Ÿช› Bugfix - [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] ๐Ÿ”ƒ Refactor of current code **๐Ÿงช How Has This Been Tested?** Tested on my personal system using the `Extra Environment Variables` configuration option. **๐Ÿ“ƒ Notes:** **โœ”๏ธ Checklist:** - [ ] โš–๏ธ My code follows the style guidelines of this project - [x] ๐Ÿ‘€ I have performed a self-review of my own code - [x] #๏ธโƒฃ I have commented my code, particularly in hard-to-understand areas - [x] ๐Ÿ“„ I have made corresponding changes to the documentation - [x] โš ๏ธ My changes generate no new warnings - [ ] ๐Ÿงช I have added tests to this description that prove my fix is effective or that my feature works - [ ] โฌ†๏ธ I increased versions for any altered app according to semantic versioning **โž• App addition** If this PR is an app addition please make sure you have done the following. - [ ] ๐Ÿชž I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] ๐Ÿ–ผ๏ธ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Codec <37117573+Jet132@users.noreply.github.com> Signed-off-by: Kjeld Schouten Co-authored-by: Kjeld Schouten --- charts/stable/etesync/Chart.yaml | 2 +- charts/stable/etesync/questions.yaml | 8 +++++++- charts/stable/etesync/values.yaml | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/charts/stable/etesync/Chart.yaml b/charts/stable/etesync/Chart.yaml index f1a89a0dd2e..a4507061931 100644 --- a/charts/stable/etesync/Chart.yaml +++ b/charts/stable/etesync/Chart.yaml @@ -1,7 +1,7 @@ kubeVersion: '>=1.24.0-0' apiVersion: v2 name: etesync -version: 5.0.13 +version: 5.1.0 appVersion: 0.11.0 description: Secure, end-to-end encrypted, and privacy respecting sync for your contacts, calendars, tasks and notes. home: https://truecharts.org/charts/stable/etesync diff --git a/charts/stable/etesync/questions.yaml b/charts/stable/etesync/questions.yaml index a16f98aedc6..31bd7d31a0f 100644 --- a/charts/stable/etesync/questions.yaml +++ b/charts/stable/etesync/questions.yaml @@ -23,7 +23,13 @@ questions: schema: additional_attrs: true type: dict - attrs: + attrs: REGEN_INI: + - variable: REGEN_INI + label: "Always recreate Config" + description: "This ensures that everytime you restart the program it recreates the config file" + schema: + type: boolean + default: true - variable: ALLOWED_HOSTS label: "ALLOWED_HOSTS" description: "Must be a valid domain or * (* is not recommended for production)" diff --git a/charts/stable/etesync/values.yaml b/charts/stable/etesync/values.yaml index b10b69cac70..59f3ab69208 100644 --- a/charts/stable/etesync/values.yaml +++ b/charts/stable/etesync/values.yaml @@ -28,6 +28,7 @@ workload: type: tcp env: PORT: "{{ .Values.service.main.ports.main.port }}" + REGEN_INI: true # App SERVER: http AUTO_UPDATE: true