fix(lancache): fix port assignments (#3798)

* Fixed lancache port assignment

* Added better label. And reverted to safe default

* Removed default ports

* Moved warning form frontend ui to documentation

* update doc

* fix ports

* Update charts/incubator/lancache-monolithic/docs/installation_notes.md

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>

* lint

* Update charts/incubator/lancache-monolithic/docs/installation_notes.md

Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros kois <s.kois@outlook.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

.devcontainer/devcontainer.json

@@ -2,7 +2,7 @@
 // https://github.com/microsoft/vscode-dev-containers/tree/v0.154.0/containers/ruby
 {
     "name": "Ruby",
-    "image": "ghcr.io/truecharts/devcontainer:v2.3.0@sha256:a163ad40427cd75a31a0365afb832f97e512d420429ed091b90b18a034526264"
+    "image": "ghcr.io/truecharts/devcontainer:v2.3.0@sha256:a163ad40427cd75a31a0365afb832f97e512d420429ed091b90b18a034526264",
 
     // Set *default* container specific settings.json values on container create.
     "settings": {

charts/incubator/lancache-dns/questions.yaml

@@ -97,6 +97,35 @@ questions:
                               type: int
                               default: 53
                               required: true
+# Include{advancedPortTCP}
+                                - variable: targetPort
+                                  label: "Target Port"
+                                  description: "The internal(!) port on the container the Application runs on"
+                                  schema:
+                                    type: int
+                                    default: 53
+        - variable: dns
+          label: "DNS Service"
+          description: "The Primary service on which the healthcheck runs, often the webUI"
+          schema:
+            additional_attrs: true
+            type: dict
+            attrs:
+# Include{serviceSelectorSimple}
+# Include{serviceSelectorExtras}
+                    - variable: dns
+                      label: "DNS Service Port Configuration"
+                      schema:
+                        additional_attrs: true
+                        type: dict
+                        attrs:
+                          - variable: port
+                            label: "Port"
+                            description: "This port exposes the container port on the service"
+                            schema:
+                              type: int
+                              default: 53
+                              required: true
 # Include{advancedPortUDP}
                                 - variable: targetPort
                                   label: "Target Port"

charts/incubator/lancache-dns/values.yaml

@@ -1,7 +1,7 @@
 image:
   repository: tccr.io/truecharts/lancache-dns
-  tag: latest@sha256:0d04cbb893f0b1da8154e2d0a9911b5e9c71f6b2dbb2e66d62e8763b4fe2a17f
   pullPolicy: IfNotPresent
+  tag: latest@sha256:0d04cbb893f0b1da8154e2d0a9911b5e9c71f6b2dbb2e66d62e8763b4fe2a17f
 
 env:
   CACHE_DOMAINS_REPO: "https://github.com/uklans/cache-domains.git"
@@ -27,6 +27,14 @@ service:
   main:
     ports:
       main:
+        port: 53
+        targetPort: 53
+
+  dns:
+    enabled: true
+    ports:
+      dns:
+        enabled: true
         protocol: UDP
         port: 53
         targetPort: 53

charts/incubator/lancache-monolithic/docs/installation_notes.md

@@ -0,0 +1,15 @@
+# Installation Notes
+
+Clients like Steam, Battle.net, etc sends requests to port 80/443.
+In case you don't want to use traefik in front of this app, you need to change the ports.
+
+- `Service` -> `Main` -> `Port`: **80**
+- `Service` -> `https` -> `Port`: **443**
+
+:::danger
+
+Doing this will break Traefik and we do NOT recommend it.
+Also, you have to make sure that you do NOT have any other service on these ports.
+Like TrueNAS Scale WebUI.
+
+:::

charts/incubator/lancache-monolithic/questions.yaml

@@ -90,6 +90,35 @@ questions:
                                   schema:
                                     type: int
                                     default: 80
+        - variable: https
+          label: "HTTPS"
+          description: "HTTPS Service"
+          schema:
+            additional_attrs: true
+            type: dict
+            attrs:
+# Include{serviceSelectorSimple}
+# Include{serviceSelectorExtras}
+                    - variable: https
+                      label: "HTTPS"
+                      schema:
+                        additional_attrs: true
+                        type: dict
+                        attrs:
+                          - variable: port
+                            label: "Port"
+                            description: "This port exposes the container port on the service"
+                            schema:
+                              type: int
+                              default: 10280
+                              required: true
+# Include{advancedPortHTTPS}
+                                - variable: targetPort
+                                  label: "Target Port"
+                                  description: "The internal(!) port on the container the Application runs on"
+                                  schema:
+                                    type: int
+                                    default: 443
 # Include{serviceExpertRoot}
             default: false
 # Include{serviceExpert}

charts/incubator/lancache-monolithic/values.yaml

@@ -27,6 +27,14 @@ service:
         port: 10279
         targetPort: 80
         protocol: HTTP
+  https:
+    enabled: true
+    ports:
+      https:
+        enabled: true
+        port: 10280
+        targetPort: 443
+        protocol: HTTPS
 
 persistence:
   config: