From 72c64f9a41130b5aec19773945d75d0e802e7150 Mon Sep 17 00:00:00 2001 From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Date: Fri, 14 Jul 2023 04:46:37 -0400 Subject: [PATCH] fix(minecraft-bedrock) fix tty and stdin and disable portal (#10427) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Portal disabled and removed. fix tty and stdin. ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [X] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/minecraft-bedrock/Chart.yaml | 2 +- .../stable/minecraft-bedrock/questions.yaml | 4 +--- charts/stable/minecraft-bedrock/values.yaml | 24 ++++++++++--------- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/charts/stable/minecraft-bedrock/Chart.yaml b/charts/stable/minecraft-bedrock/Chart.yaml index 934b466eed7..ff1fda2b0d2 100644 --- a/charts/stable/minecraft-bedrock/Chart.yaml +++ b/charts/stable/minecraft-bedrock/Chart.yaml @@ -20,7 +20,7 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/stable/minecraft-bedrock - https://github.com/itzg/docker-minecraft-server type: application -version: 4.0.23 +version: 4.0.24 annotations: truecharts.org/catagories: | - games diff --git a/charts/stable/minecraft-bedrock/questions.yaml b/charts/stable/minecraft-bedrock/questions.yaml index 35e45bcabb1..4cc1ad18769 100644 --- a/charts/stable/minecraft-bedrock/questions.yaml +++ b/charts/stable/minecraft-bedrock/questions.yaml @@ -1,7 +1,5 @@ # Include{groups} -portals: - open: -# Include{portalLink} +portals: {} questions: # Include{global} # Include{workload} diff --git a/charts/stable/minecraft-bedrock/values.yaml b/charts/stable/minecraft-bedrock/values.yaml index cb56549e2ba..22d52c08fad 100644 --- a/charts/stable/minecraft-bedrock/values.yaml +++ b/charts/stable/minecraft-bedrock/values.yaml @@ -2,28 +2,21 @@ image: repository: tccr.io/truecharts/minecraft-bedrock tag: 2022.1.0@sha256:85b2493240d4c6ac69f8383937510c432812072ebd5ef382ebe6ba7f325d70ed pullPolicy: Always -tty: true -stdin: true -persistence: - config: - enabled: true - mountPath: "/data" + service: main: ports: main: port: 19132 - targetPort: 19132 protocol: udp -portal: - open: - enabled: true workload: main: podSpec: containers: main: + tty: true + stdin: true probes: # -- Liveness probe configuration # @default -- See below @@ -41,7 +34,7 @@ workload: EULA: "TRUE" VERSION: "LATEST" SERVER_NAME: "TrueCharts Dedicated Server!" - SERVER_PORT: "{{ .Values.service.main.ports.main.targetPort }}" + SERVER_PORT: "{{ .Values.service.main.ports.main.port }}" SERVER_PORT_V6: 19133 GAMEMODE: "survival" DIFFICULTY: "easy" @@ -64,3 +57,12 @@ workload: PLAYER_MOVEMENT_DURATION_THRESHOLD_IN_MS: 500 CORRECT_PLAYER_MOVEMENT: false # OPS: "XUID,XUID" + +persistence: + config: + enabled: true + mountPath: "/data" + +portal: + open: + enabled: false