diff --git a/charts/stable/external-dns/Chart.yaml b/charts/stable/external-dns/Chart.yaml index 795d24653f1..1996070a198 100644 --- a/charts/stable/external-dns/Chart.yaml +++ b/charts/stable/external-dns/Chart.yaml @@ -36,5 +36,5 @@ sources: - https://github.com/kubernetes-sigs/external-dns - https://github.com/truecharts/charts/tree/master/charts/stable/external-dns type: application -version: 6.8.0 +version: 6.9.0 diff --git a/charts/stable/external-dns/docs/setup-guide.md b/charts/stable/external-dns/docs/setup-guide.md index 89096532583..1cf233ff283 100644 --- a/charts/stable/external-dns/docs/setup-guide.md +++ b/charts/stable/external-dns/docs/setup-guide.md @@ -71,19 +71,20 @@ If this works, you'll see DNS entries inside Cloudflare's DNS page. ### PiHole -:::danger[Temporally broken] - -Because of API changes in Pi-hole v6 this is temporally broken. -More info: https://github.com/kubernetes-sigs/external-dns/issues/5113 - -::: - #### Step 1 - Set `pihole` as provider - set sources `ingress` and `service` should covers everything - Recommend using `noop` for `registry` - Set PiHole Server Address `piholeServer` and PiHole Server Password `piholePassword` +- Set `piholeAPIVersion` depending on which version of PiHole you have installed i.e. 5 or 6 + +:::caution[Future deprecation] + +The option for version 5 of the PiHole api will be deprecated in a future External DNS release. +More info: https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/pihole.md + +::: ```yaml externaldns: @@ -100,6 +101,7 @@ More info: https://github.com/kubernetes-sigs/external-dns/issues/5113 policy: "upsert-only" # would prevent ExternalDNS from deleting any records, omit to enable full synchronization piholeServer: "http://pihole.pihole.svc.cluster.local:8089" piholePassword: "DitIsSuperGeheim" + piholeAPIVersion: "6" ``` #### Step 2 diff --git a/charts/stable/external-dns/templates/_args.tpl b/charts/stable/external-dns/templates/_args.tpl index b6e7f0453cf..d79a3918729 100644 --- a/charts/stable/external-dns/templates/_args.tpl +++ b/charts/stable/external-dns/templates/_args.tpl @@ -45,4 +45,7 @@ args: {{- with .Values.externaldns.piholePassword }} - --pihole-password={{ . }} {{- end -}} + {{- with .Values.externaldns.piholeAPIVersion }} + - --pihole-api-version={{ . }} + {{- end -}} {{- end -}} diff --git a/charts/stable/external-dns/values.yaml b/charts/stable/external-dns/values.yaml index dcd3d6b8f46..6ad85961adc 100644 --- a/charts/stable/external-dns/values.yaml +++ b/charts/stable/external-dns/values.yaml @@ -17,6 +17,7 @@ externaldns: policy: "" piholeServer: "" piholePassword: "" + piholeAPIVersion: "" triggerLoopOnEvent: "false" txtOwnerId: "" txtPrefix: ""