From 62752e721a9523ea32f042420b06ab84931d8864 Mon Sep 17 00:00:00 2001 From: Boemeltrein <130394941+Boemeltrein@users.noreply.github.com> Date: Tue, 10 Jun 2025 22:24:34 +0200 Subject: [PATCH] fix(volsync): kube-rbac-proxy - probes (#36192) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes # 1. Depricated Flag ``` W0610 19:41:20.647288 1 deprecated.go:66] ==== Removed Flag Warning ====================== logtostderr is removed in the k8s upstream and has no effect any more. =============================================== ``` 2. A lot probe errors like: ``` I0610 19:41:34.996469 1 log.go:245] http: TLS handshake error from 192.168.1.181:56688: EOF I0610 19:41:46.997501 1 log.go:245] http: TLS handshake error from 192.168.1.181:32894: EOF I0610 19:41:49.996092 1 log.go:245] http: TLS handshake error from 192.168.1.181:32902: EOF ``` **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [x] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code - [ ] 📜 Documentation Changes **🧪 How Has This Been Tested?** My own cluster: https://github.com/Boemeltrein/TalosCluster/commit/d3b0d5bac75eb99c0966eaf6eef348f9dfa09301 **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made changes to the documentation - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning - [x] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or `fix(docs):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/system/volsync/Chart.yaml | 2 +- charts/system/volsync/values.yaml | 17 ++++++++++------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/charts/system/volsync/Chart.yaml b/charts/system/volsync/Chart.yaml index 4d12987985f..c6c8e9bd073 100644 --- a/charts/system/volsync/Chart.yaml +++ b/charts/system/volsync/Chart.yaml @@ -39,5 +39,5 @@ sources: - https://quay.io/brancz/kube-rbac-proxy - https://volsync.readthedocs.io/ type: application -version: 2.11.2 +version: 2.11.3 diff --git a/charts/system/volsync/values.yaml b/charts/system/volsync/values.yaml index 57517b92904..22808ccfaec 100644 --- a/charts/system/volsync/values.yaml +++ b/charts/system/volsync/values.yaml @@ -42,7 +42,7 @@ workload: args: - --secure-listen-address=0.0.0.0:8443 - --upstream=http://127.0.0.1:8080/ - - --logtostderr=true + - --proxy-endpoints-port=8888 - "--tls-min-version=VersionTLS12" - --v=0 - --ignore-paths=/metrics @@ -55,14 +55,17 @@ workload: memory: 64Mi probes: liveness: - type: tcp - port: 8443 + type: https + port: 8888 + path: /healthz readiness: - type: tcp - port: 8443 + type: https + port: 8888 + path: /healthz startup: - type: tcp - port: 8443 + type: https + port: 8888 + path: /healthz # -- Options for all pods # Can be overruled per pod