Chore(Apps): Simplify GUI for deployment, persistence and securityContext (#1289)

* update deployment settings

* hide securityContext by default

* replace bottom persistence section with include

* temporaryly remove hostPathType

* Cleanup basic persistence settings

* Allow simplePVC to also be used for volumeClaimTemplates

charts/stable/kms/questions.yaml

@@ -22,41 +22,48 @@ questions:
     schema:
       type: dict
       attrs:
-        - variable: type
-          description: "Please specify type of workload to deploy"
-          label: "(Advanced) Controller Type"
+        - variable: advanced
+          label: "Show Advanced Controller Settings"
           schema:
-            type: string
-            default: "deployment"
-            required: true
-            enum:
-              - value: "deployment"
-                description: "Deployment"
-              - value: "statefulset"
-                description: "Statefulset"
-              - value: "daemonset"
-                description: "Daemonset"
-        - variable: replicas
-          description: "Number of desired pod replicas"
-          label: "Desired Replicas"
-          schema:
-            type: int
-            default: 1
-            required: true
-        - variable: strategy
-          description: "Please specify type of workload to deploy"
-          label: "(Advanced) Update Strategy"
-          schema:
-            type: string
-            default: "RollingUpdate"
-            required: true
-            enum:
-              - value: "Recreate"
-                description: "Recreate: Kill existing pods before creating new ones"
-              - value: "RollingUpdate"
-                description: "RollingUpdate: Create new pods and then kill old ones"
-              - value: "OnDelete"
-                description: "(Legacy) OnDelete: ignore .spec.template changes"
+            type: boolean
+            default: false
+            show_subquestions_if: true
+            subquestions:
+              - variable: type
+                description: "Please specify type of workload to deploy"
+                label: "(Advanced) Controller Type"
+                schema:
+                  type: string
+                  default: "deployment"
+                  required: true
+                  enum:
+                    - value: "deployment"
+                      description: "Deployment"
+                    - value: "statefulset"
+                      description: "Statefulset"
+                    - value: "daemonset"
+                      description: "Daemonset"
+              - variable: replicas
+                description: "Number of desired pod replicas"
+                label: "Desired Replicas"
+                schema:
+                  type: int
+                  default: 1
+                  required: true
+              - variable: strategy
+                description: "Please specify type of workload to deploy"
+                label: "(Advanced) Update Strategy"
+                schema:
+                  type: string
+                  default: "RollingUpdate"
+                  required: true
+                  enum:
+                    - value: "Recreate"
+                      description: "Recreate: Kill existing pods before creating new ones"
+                    - value: "RollingUpdate"
+                      description: "RollingUpdate: Create new pods and then kill old ones"
+                    - value: "OnDelete"
+                      description: "(Legacy) OnDelete: ignore .spec.template changes"
 # Include{controllerExpert}
   - variable: env
     group: "Container Configuration"
@@ -202,32 +209,39 @@ questions:
 
 # Include{ingressList}
 
-  - variable: securityContext
+  - variable: advancedSecurity
+    label: "Show Advanced Security Settings"
     group: "Security and Permissions"
-    label: "Security Context"
     schema:
-      type: dict
-      attrs:
-        - variable: privileged
-          label: "Privileged mode"
+      type: boolean
+      default: false
+      show_subquestions_if: true
+      subquestions:
+        - variable: securityContext
+          label: "Security Context"
           schema:
-            type: boolean
-            default: false
-        - variable: readOnlyRootFilesystem
-          label: "ReadOnly Root Filesystem"
-          schema:
-            type: boolean
-            default: false
-        - variable: allowPrivilegeEscalation
-          label: "Allow Privilege Escalation"
-          schema:
-            type: boolean
-            default: false
-        - variable: runAsNonRoot
-          label: "runAsNonRoot"
-          schema:
-            type: boolean
-            default: false
+            type: dict
+            attrs:
+              - variable: privileged
+                label: "Privileged mode"
+                schema:
+                  type: boolean
+                  default: false
+              - variable: readOnlyRootFilesystem
+                label: "ReadOnly Root Filesystem"
+                schema:
+                  type: boolean
+                  default: false
+              - variable: allowPrivilegeEscalation
+                label: "Allow Privilege Escalation"
+                schema:
+                  type: boolean
+                  default: false
+              - variable: runAsNonRoot
+                label: "runAsNonRoot"
+                schema:
+                  type: boolean
+                  default: false
 
   - variable: podSecurityContext
     group: "Security and Permissions"