From 570baae0238ccb56ac39ad9850154d73eba2f746 Mon Sep 17 00:00:00 2001
From: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Date: Sun, 20 Feb 2022 16:10:14 +0200
Subject: [PATCH] chore(nextcloud): clrearly indicate values that used only on
 first install (#1909)

* chore(nextcloud): clrearly indicate values that used only on first install

* cleanup values
---
 charts/stable/nextcloud/questions.yaml |  4 ++--
 charts/stable/nextcloud/values.yaml    | 26 ++------------------------
 2 files changed, 4 insertions(+), 26 deletions(-)

diff --git a/charts/stable/nextcloud/questions.yaml b/charts/stable/nextcloud/questions.yaml
index 7e11bdef241..3232ed5dcd4 100644
--- a/charts/stable/nextcloud/questions.yaml
+++ b/charts/stable/nextcloud/questions.yaml
@@ -105,13 +105,13 @@ questions:
       attrs:
 # Include{fixedEnv}
         - variable: TRUSTED_PROXIES
-          label: "Trusted Proxies (Advanced)"
+          label: "Trusted Proxies (First Install Only - Advanced)"
           description: "Sets nextcloud Trusted Proxies"
           schema:
             type: string
             default: "172.16.0.0/16"
         - variable: NODE_IP
-          label: "NODE_IP"
+          label: "NODE_IP (First Install Only)"
           description: "Sets nextcloud nodeip for nodeport connections (Ensure this is correct at first install!)"
           schema:
             type: string
diff --git a/charts/stable/nextcloud/values.yaml b/charts/stable/nextcloud/values.yaml
index 0feb33e1544..a8068061f1f 100644
--- a/charts/stable/nextcloud/values.yaml
+++ b/charts/stable/nextcloud/values.yaml
@@ -28,6 +28,7 @@ service:
 secret:
   NEXTCLOUD_ADMIN_USER: "admin"
   NEXTCLOUD_ADMIN_PASSWORD: "adminpass"
+
 env:
   TRUSTED_PROXIES: "172.16.0.0/16"
   POSTGRES_DB: "{{ .Values.postgresql.postgresqlDatabase }}"
@@ -59,16 +60,10 @@ persistence:
   data:
     enabled: true
     mountPath: "/var/www/html"
-# -- Probe configuration
-# -- [[ref]](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/)
-# @default -- See below
+
 probes:
-  # -- Liveness probe configuration
-  # @default -- See below
   liveness:
     custom: true
-    # -- If a HTTP probe is used (default for HTTP/HTTPS services) this path is used
-    # @default -- "/"
     spec:
       httpGet:
         path: /status.php
@@ -77,12 +72,8 @@ probes:
         - name: Host
           value: "test.fakedomain.dns"
 
-  # -- Redainess probe configuration
-  # @default -- See below
   readiness:
     custom: true
-    # -- If a HTTP probe is used (default for HTTP/HTTPS services) this path is used
-    # @default -- "/"
     spec:
       httpGet:
         path: /status.php
@@ -91,12 +82,8 @@ probes:
         - name: Host
           value: "test.fakedomain.dns"
 
-  # -- Startup probe configuration
-  # @default -- See below
   startup:
     custom: true
-    # -- If a HTTP probe is used (default for HTTP/HTTPS services) this path is used
-    # @default -- "/"
     spec:
       httpGet:
         path: /status.php
@@ -105,27 +92,18 @@ probes:
         - name: Host
           value: "test.fakedomain.dns"
 
-## Cronjob to execute Nextcloud background tasks
-## ref: https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/background_jobs_configuration.html#webcron
-##
 cronjob:
-  # Every 5 minutes
-  # Note: Setting this to any any other value than 5 minutes might
-  #  cause issues with how nextcloud background jobs are executed
   schedule: "*/5 * * * *"
   annotations: {}
   failedJobsHistoryLimit: 5
   successfulJobsHistoryLimit: 2
 
-# Enabled postgres
 postgresql:
   enabled: true
   existingSecret: "dbcreds"
   postgresqlUsername: nextcloud
   postgresqlDatabase: nextcloud
 
-# Enabled redis
-# ... for more options see https://github.com/tccr.io/truecharts/charts/tree/master/tccr.io/truecharts/redis
 redis:
   enabled: true
   existingSecret: "rediscreds"