refactor(charts): BREAKING CHANGE (#2836)

* Update Apps with new Common version

* Patch with the secret fixes from common

* fix amd

charts/stable/mkvtoolnix/Chart.yaml

@@ -3,7 +3,7 @@ appVersion: "1.63.0"
 dependencies:
 - name: common
   repository: https://library-charts.truecharts.org
-  version: 9.3.24
+  version: 10.0.8
 deprecated: false
 description: MKVToolNix is a set of tools to create, alter and inspect Matroska files.
 home: https://github.com/truecharts/apps/tree/master/charts/stable/mkvtoolnix
@@ -23,7 +23,7 @@ sources:
 - https://hub.docker.com/r/jlesage/mkvtoolnix
 - https://mkvtoolnix.download/
 type: application
-version: 1.0.7
+version: 2.0.0
 annotations:
   truecharts.org/catagories: |
     - media

charts/stable/mkvtoolnix/SCALE/migrations/migrate

@@ -0,0 +1,21 @@
+#!/usr/bin/python3
+import json
+import os
+import sys
+
+
+def migrate(values):
+    values.update({
+        **({'secretEnv': values['secret']} if values.get('secret') else {}),
+        **({'secret': {}} if values.get('secret'))
+    })
+    return values
+
+
+if __name__ == '__main__':
+    if len(sys.argv) != 2:
+        exit(1)
+
+    if os.path.exists(sys.argv[1]):
+        with open(sys.argv[1], 'r') as f:
+            print(json.dumps(migrate(json.loads(f.read()))))

charts/stable/mkvtoolnix/questions.yaml

@@ -75,7 +75,7 @@ questions:
                     - value: "OnDelete"
                       description: "(Legacy) OnDelete: ignore .spec.template changes"
 # Include{controllerExpert}
-  - variable: secret
+  - variable: secretEnv
     group: "Container Configuration"
     label: "Image Secrets"
     schema:

charts/stable/mkvtoolnix/templates/common.yaml

@@ -1 +1 @@
-{{ include "common.all" . }}
+{{ include "tc.common.loader.all" . }}

charts/stable/mkvtoolnix/values.yaml

@@ -27,9 +27,9 @@ service:
 
 envFrom:
   - configMapRef:
-      name: '{{ include "common.names.fullname" . }}-mkvtoolnix'
+      name: '{{ include "tc.common.names.fullname" . }}-mkvtoolnix'
 
-secret:
+secretEnv:
   VNC_PASSWORD: ""
 
 mkvtoolnix: