refactor(charts): BREAKING CHANGE (#2836)

* Update Apps with new Common version

* Patch with the secret fixes from common

* fix amd

charts/stable/icinga2/Chart.yaml

@@ -3,7 +3,7 @@ appVersion: "2.13.3"
 dependencies:
 - name: common
   repository: https://library-charts.truecharts.org
-  version: 9.3.24
+  version: 10.0.8
 - condition: mariadb.enabled
   name: mariadb
   repository: https://charts.truecharts.org/
@@ -23,7 +23,7 @@ name: icinga2
 sources:
 - https://github.com/jjethwa/icinga2
 - https://icinga.com/
-version: 1.0.25
+version: 2.0.0
 annotations:
   truecharts.org/catagories: |
     - monitoring

charts/stable/icinga2/SCALE/migrations/migrate

@@ -0,0 +1,21 @@
+#!/usr/bin/python3
+import json
+import os
+import sys
+
+
+def migrate(values):
+    values.update({
+        **({'secretEnv': values['secret']} if values.get('secret') else {}),
+        **({'secret': {}} if values.get('secret'))
+    })
+    return values
+
+
+if __name__ == '__main__':
+    if len(sys.argv) != 2:
+        exit(1)
+
+    if os.path.exists(sys.argv[1]):
+        with open(sys.argv[1], 'r') as f:
+            print(json.dumps(migrate(json.loads(f.read()))))

charts/stable/icinga2/templates/common.yaml

@@ -1 +1 @@
-{{ include "common.all" . }}
+{{ include "tc.common.loader.all" . }}

charts/stable/icinga2/values.yaml

@@ -7,6 +7,18 @@ image:
 # @default -- See below
 env:
   DEFAULT_MYSQL_USER: icinga2
+  DEFAULT_MYSQL_HOST:
+    secretKeyRef:
+      name: mariadbcreds
+      key: plainhost
+  DEFAULT_MYSQL_PASS:
+    secretKeyRef:
+      name: mariadbcreds
+      key: mariadb-password
+  MYSQL_ROOT_PASSWORD:
+    secretKeyRef:
+      name: mariadbcreds
+      key: mariadb-root-password
 
 securityContext:
   readOnlyRootFilesystem: false
@@ -63,20 +75,6 @@ persistence:
     enabled: true
     mountPath: "/etc/ssmtp"
 
-envValueFrom:
-  DEFAULT_MYSQL_HOST:
-    secretKeyRef:
-      name: mariadbcreds
-      key: plainhost
-  DEFAULT_MYSQL_PASS:
-    secretKeyRef:
-      name: mariadbcreds
-      key: mariadb-password
-  MYSQL_ROOT_PASSWORD:
-    secretKeyRef:
-      name: mariadbcreds
-      key: mariadb-root-password
-
 mariadb:
   enabled: true
   mariadbUsername: icinga2