From 4fc5f64101b579adf1f646ccc79c162970ab673c Mon Sep 17 00:00:00 2001 From: Alec Fenichel Date: Fri, 28 Jul 2023 17:50:46 -0400 Subject: [PATCH] fix(channels-dvr) revert permissions changes and add installation note (#10854) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes # Revert permissions changed in https://github.com/truecharts/charts/pull/10813 and add installation note instead. **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [x] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [x] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/channels-dvr/Chart.yaml | 2 +- charts/stable/channels-dvr/docs/installation_notes.md | 11 +++++++---- charts/stable/channels-dvr/questions.yaml | 6 +++--- charts/stable/channels-dvr/values.yaml | 6 ------ 4 files changed, 11 insertions(+), 14 deletions(-) diff --git a/charts/stable/channels-dvr/Chart.yaml b/charts/stable/channels-dvr/Chart.yaml index 4e8526345d6..52885bda0e0 100644 --- a/charts/stable/channels-dvr/Chart.yaml +++ b/charts/stable/channels-dvr/Chart.yaml @@ -19,7 +19,7 @@ name: channels-dvr sources: - https://github.com/truecharts/charts/tree/master/charts/stable/channels-dvr type: application -version: 2.1.2 +version: 2.1.3 annotations: truecharts.org/catagories: | - media diff --git a/charts/stable/channels-dvr/docs/installation_notes.md b/charts/stable/channels-dvr/docs/installation_notes.md index f7b6c07aca2..14e4745f658 100644 --- a/charts/stable/channels-dvr/docs/installation_notes.md +++ b/charts/stable/channels-dvr/docs/installation_notes.md @@ -1,16 +1,19 @@ # Channels DVR Installation Notes -:::danger Ingress +:::danger TV Everywhere Permissions + +If using TV Everywhere, `runAsUser` and `runAsGroup` must both be changed to `0` and `readOnlyRootFilesystem` must be changed to `false`. + +::: + +## Ingress You cannot use Ingress during the initial setup. The Channels DVR Server web interface must be accessed using the TrueNAS server IP and Channels DVR Server port (defaults to 8089). After initial setup, ingress can be used to access the Channels DVR Server web interface. -::: - ## Login During initial setup on the Channels DVR Server web interface, you will need to login to your Channels DVR website account as described here: [https://getchannels.com/docs/channels-dvr-server/quick-guide/installation-setup/#log-in](https://getchannels.com/docs/channels-dvr-server/quick-guide/installation-setup/#log-in). After you login on the Channels DVR website, you will be redirected back to your local Channels DVR Server web interface. However, the redirect will use the internal Kubernetes IP in the URL so it will not work. Simply change the IP in the URL to the IP of you TrueNAS server leaving the path and query parameters unmodified. - diff --git a/charts/stable/channels-dvr/questions.yaml b/charts/stable/channels-dvr/questions.yaml index f12d2d70d59..fc496d05140 100644 --- a/charts/stable/channels-dvr/questions.yaml +++ b/charts/stable/channels-dvr/questions.yaml @@ -20,7 +20,7 @@ questions: - value: image description: Channels DVR - value: tveImage - description: Channels DVR with TV Everywhere + description: Channels DVR with TV Everywhere (see installation notes) # Include{containerBasic} # Include{containerAdvanced} @@ -83,13 +83,13 @@ questions: description: "The UserID of the user running the application" schema: type: int - default: 0 + default: 568 - variable: runAsGroup label: "runAsGroup" description: "The groupID this App of the user running the application" schema: type: int - default: 0 + default: 568 # Include{securityContextContainer} # Include{securityContextAdvanced} # Include{securityContextPod} diff --git a/charts/stable/channels-dvr/values.yaml b/charts/stable/channels-dvr/values.yaml index 457eb9cc3c0..5d1b32a5b65 100644 --- a/charts/stable/channels-dvr/values.yaml +++ b/charts/stable/channels-dvr/values.yaml @@ -8,12 +8,6 @@ tveImage: pullPolicy: Always tag: latest@sha256:7e0130ad244e07f3714edadecdcc8711d9d3c11eac8409705b5c6aa8e108ca7e -securityContext: - container: - readOnlyRootFilesystem: false - runAsUser: 0 - runAsGroup: 0 - service: main: ports: