From 4cf58b48b16a348b723a14b0ec73a8e6ddb079bc Mon Sep 17 00:00:00 2001 From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Date: Sat, 30 Mar 2024 08:22:30 -0400 Subject: [PATCH] fix(neko) fix neko add missing env variable (#19977) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Fix neko chart. ⚒️ Fixes #19919 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning - [X] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):` or `chore(chart-name):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/neko/questions.yaml | 6 ++++++ charts/stable/neko/values.yaml | 2 ++ 2 files changed, 8 insertions(+) diff --git a/charts/stable/neko/questions.yaml b/charts/stable/neko/questions.yaml index 61e1c30f97e..80427a10816 100644 --- a/charts/stable/neko/questions.yaml +++ b/charts/stable/neko/questions.yaml @@ -46,6 +46,12 @@ questions: additional_attrs: true type: dict attrs: + - variable: ip + label: IP + description: IP of the server that will be sent to client, if not specified, public IP is automatically resolved. + schema: + type: string + default: "0.0.0.0" - variable: auth label: Auth Credentials schema: diff --git a/charts/stable/neko/values.yaml b/charts/stable/neko/values.yaml index 63957583e17..58ef4b10536 100644 --- a/charts/stable/neko/values.yaml +++ b/charts/stable/neko/values.yaml @@ -64,6 +64,7 @@ service: protocol: udp neko: + ip: "0.0.0.0" auth: user_pass: "" admin_pass: "" @@ -88,6 +89,7 @@ workload: env: NEKO_BIND: '{{ printf ":%v" .Values.service.main.ports.main.port }}' NEKO_PATH_PREFIX: "/" + NEKO_NAT1TO1: "{{ .Values.neko.ip }}" # NEKO_EPR NEKO_TCPMUX: "{{ .Values.service.mux.ports.tcp.port }}" NEKO_UDPMUX: "{{ .Values.service.mux.ports.tcp.port }}"