From 4b3050f37983a5dc47fc5532a94b7f5500f7c5d3 Mon Sep 17 00:00:00 2001 From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Date: Fri, 14 Jul 2023 04:53:17 -0400 Subject: [PATCH] fix(technitium) fix technitium service gui (#10349) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Fixes the Expected enabled service to have at least one port by removing a excess option. ⚒️ Fixes #10348 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [X] ⚖️ My code follows the style guidelines of this project - [X] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [X] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/incubator/technitium/Chart.yaml | 2 +- charts/incubator/technitium/questions.yaml | 22 ---------------------- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/charts/incubator/technitium/Chart.yaml b/charts/incubator/technitium/Chart.yaml index 7c7bb642647..92ad919aa10 100644 --- a/charts/incubator/technitium/Chart.yaml +++ b/charts/incubator/technitium/Chart.yaml @@ -21,7 +21,7 @@ sources: - https://github.com/TechnitiumSoftware/DnsServer - https://technitium.com/ type: application -version: 4.0.0 +version: 4.0.1 annotations: truecharts.org/catagories: | - networking diff --git a/charts/incubator/technitium/questions.yaml b/charts/incubator/technitium/questions.yaml index f0ebc966390..c26a01a6bf7 100644 --- a/charts/incubator/technitium/questions.yaml +++ b/charts/incubator/technitium/questions.yaml @@ -141,28 +141,6 @@ questions: type: int default: 5380 required: true - - variable: dns-udp - label: "DNS-UDP Service" - description: "DNS-UDP Service" - schema: - additional_attrs: true - type: dict - attrs: -# Include{serviceSelectorLoadBalancer} -# Include{serviceSelectorExtras} - - variable: dns-udp - label: "DNS-UDP Service Port Configuration" - schema: - additional_attrs: true - type: dict - attrs: - - variable: port - label: "Port" - description: "This port exposes the container port on the service" - schema: - type: int - default: 53 - required: true - variable: dns label: "DNS Service" description: "DNS Service"