From 487d16f673210c37d74160c7bcf53753ad9e3bc4 Mon Sep 17 00:00:00 2001
From: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Date: Mon, 25 Dec 2023 22:32:47 +0200
Subject: [PATCH] fix(pihole): fix quoting (#16538)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  #11798

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/stable/pihole/Chart.yaml               | 2 +-
 charts/stable/pihole/templates/_configmap.tpl | 2 +-
 charts/stable/pihole/values.yaml              | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/charts/stable/pihole/Chart.yaml b/charts/stable/pihole/Chart.yaml
index 8816d1dc7d7..6d795442223 100644
--- a/charts/stable/pihole/Chart.yaml
+++ b/charts/stable/pihole/Chart.yaml
@@ -1,7 +1,7 @@
 kubeVersion: ">=1.24.0-0"
 apiVersion: v2
 name: pihole
-version: 13.0.0
+version: 13.0.1
 appVersion: 2023.11.0
 description: DNS and Ad-filtering for your network
 home: https://truecharts.org/charts/stable/pihole
diff --git a/charts/stable/pihole/templates/_configmap.tpl b/charts/stable/pihole/templates/_configmap.tpl
index d39976e9e89..e2d62dd488d 100644
--- a/charts/stable/pihole/templates/_configmap.tpl
+++ b/charts/stable/pihole/templates/_configmap.tpl
@@ -4,7 +4,7 @@ configmap:
   pihole-env:
     enabled: true
     data:
-      WEBPASSWORD: {{ .Values.pihole.webPassword | squote }}
+      WEBPASSWORD: {{ .Values.pihole.webPassword | quote }}
       {{- with .Values.pihole.dnsServers }}
         {{- if gt (len .) 2 -}}
           {{- fail (printf "Pihole - Expected max 2 DNS Servers. But got [%v]" (len .)) -}}
diff --git a/charts/stable/pihole/values.yaml b/charts/stable/pihole/values.yaml
index 6ccefd04ab5..c4edd5db39c 100644
--- a/charts/stable/pihole/values.yaml
+++ b/charts/stable/pihole/values.yaml
@@ -3,7 +3,7 @@ image:
   pullPolicy: IfNotPresent
   tag: 2023.11.0@sha256:24b1ef8f66d810faffefdb9b66850bbe2d55013506b892605acef414e210edeb
 pihole:
-  webPassword: "somepassword"
+  webPassword: somepassword"
   dnsServers:
     - "9.9.9.9"
     - "149.112.112.112"