From 485b71774771b079e9e38707c1841231a75ff75a Mon Sep 17 00:00:00 2001 From: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Date: Sun, 30 Jul 2023 23:32:47 +0300 Subject: [PATCH] fix(funkwhale): fix port (#11062) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** ⚒️ Fixes # **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/incubator/funkwhale/Chart.yaml | 2 +- charts/incubator/funkwhale/values.yaml | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/charts/incubator/funkwhale/Chart.yaml b/charts/incubator/funkwhale/Chart.yaml index e85938709fd..c2f1e4b2c0b 100644 --- a/charts/incubator/funkwhale/Chart.yaml +++ b/charts/incubator/funkwhale/Chart.yaml @@ -27,4 +27,4 @@ sources: - https://github.com/truecharts/charts/tree/master/charts/incubator/funkwhale - https://funkwhale.audio/ type: application -version: 3.0.0 +version: 3.0.1 diff --git a/charts/incubator/funkwhale/values.yaml b/charts/incubator/funkwhale/values.yaml index 4af67921fee..4f820c9a43a 100644 --- a/charts/incubator/funkwhale/values.yaml +++ b/charts/incubator/funkwhale/values.yaml @@ -3,6 +3,11 @@ image: repository: tccr.io/truecharts/funkwhale tag: 1.2.10@sha256:835a4970cd330024e617e6b320f609b700ee79f042b57118ad761605fbd985d1 +# TODO: multi pod setup +# Some examples: +# - https://gitlab.com/ananace/charts/-/tree/master/charts/funkwhale/templates +# - https://dev.funkwhale.audio/funkwhale/funkwhale/-/blob/develop/deploy/env.prod.sample + securityContext: container: readOnlyRootFilesystem: false @@ -16,7 +21,8 @@ workload: containers: main: env: - FUNKWHALE_HOSTNAME: "yourdomain.funkwhale" + FUNKWHALE_HOSTNAME: "http://localhost:{{ .Values.service.main.ports.main.port }}" + FUNKWHALE_API_PORT: "{{ .Values.service.main.ports.main.port }}" NESTED_PROXY: "0" DJANGO_SECRET_KEY: secretKeyRef: @@ -29,7 +35,6 @@ service: main: port: 10236 protocol: http - targetPort: 5000 persistence: data: