From 33d6ecb9c9d15fe672dbde27a352780b541c9e0b Mon Sep 17 00:00:00 2001 From: edgar131 Date: Fri, 12 May 2023 05:54:23 -0400 Subject: [PATCH] feat(custom-app) Enable Options for Configuring Portal & bump app version (#8805) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** Adds support to custom-app to enable/disable the web portal as well as configure override settings for the port/host/protocol. ⚒️ Fixes # #8793 **⚙️ Type of change** - [x] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** I copied my updated section of questions.yaml into the questions.yaml in my personal catalog and installed various scenarios of enabling/disabling and overriding parameters. **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --- charts/stable/custom-app/Chart.yaml | 2 +- charts/stable/custom-app/questions.yaml | 59 +++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 1 deletion(-) diff --git a/charts/stable/custom-app/Chart.yaml b/charts/stable/custom-app/Chart.yaml index aad6e76d8df..abd0ddfe7fb 100644 --- a/charts/stable/custom-app/Chart.yaml +++ b/charts/stable/custom-app/Chart.yaml @@ -19,7 +19,7 @@ name: custom-app sources: - https://github.com/truecharts/charts/tree/master/charts/stable/custom-app type: application -version: 8.0.7 +version: 8.0.8 annotations: truecharts.org/catagories: | - custom diff --git a/charts/stable/custom-app/questions.yaml b/charts/stable/custom-app/questions.yaml index 9c31f00a61a..1f0fd331cd6 100644 --- a/charts/stable/custom-app/questions.yaml +++ b/charts/stable/custom-app/questions.yaml @@ -154,6 +154,65 @@ questions: schema: type: string default: "/" + - variable: portal + group: "General Settings" + label: "Portal Configuration" + schema: + type: dict + additional_attrs: true + attrs: + - variable: open + label: "Open" + schema: + type: dict + additional_attrs: true + attrs: + - variable: enabled + label: "Enable WebUI Portal" + description: "Enable WebUI Portal" + schema: + type: boolean + default: true + - variable: overrides + label: "Override Portal Configuration" + description: "Override Portal Configuration" + schema: + type: boolean + default: false + show_if: [["enabled", "=", true]] + show_subquestions_if: true + subquestions: + - variable: override + label: "Override Portal Configuration" + description: "Override Portal Configuration" + schema: + type: dict + additional_attrs: true + attrs: + - variable: protocol + label: "Protocol" + description: "Portal Protocol Override" + schema: + type: string + enum: + - value: "" + description: "" + - value: "http" + description: "HTTP" + - value: "https" + description: "HTTPS" + - variable: host + label: "Host" + description: "Portal Host Override" + schema: + type: string + default: "" + - variable: port + label: "Port" + description: "Portal Port Override" + schema: + type: string + default: "" # Include{containerConfig} # Include{podOptions} # Include{serviceRoot}