From 31789854ce5d4b9365a5f7d0e3f6871d97df6a86 Mon Sep 17 00:00:00 2001 From: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Date: Tue, 5 Apr 2022 11:22:23 +0300 Subject: [PATCH] chore(openvsvode-server): make connectionToken optional as it changed upstream (#2428) --- charts/stable/openvscode-server/Chart.yaml | 2 +- charts/stable/openvscode-server/questions.yaml | 9 ++++++++- charts/stable/openvscode-server/values.yaml | 8 ++++---- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/charts/stable/openvscode-server/Chart.yaml b/charts/stable/openvscode-server/Chart.yaml index 7c9114a9ff2..a20375a4511 100644 --- a/charts/stable/openvscode-server/Chart.yaml +++ b/charts/stable/openvscode-server/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 kubeVersion: ">=1.16.0-0" name: openvscode-server -version: 1.0.11 +version: 1.0.12 appVersion: "1.66.0" description: Openvscode-server provides a version of VS Code that runs a server on a remote machine. type: application diff --git a/charts/stable/openvscode-server/questions.yaml b/charts/stable/openvscode-server/questions.yaml index f194887bb3a..2a1c53a9eec 100644 --- a/charts/stable/openvscode-server/questions.yaml +++ b/charts/stable/openvscode-server/questions.yaml @@ -84,13 +84,20 @@ questions: attrs: - variable: CONNECTION_TOKEN label: "CONNECTION_TOKEN" + description: "Optional security token for accessing the Web UI (ie. supersecrettoken)." schema: type: string private: true - required: true + default: "" + - variable: CONNECTION_SECRET + label: "CONNECTION_SECRET" + description: "Optional path to a file inside the container that contains the security token for accessing the Web UI (ie. /path/to/file). Overrides CONNECTION_TOKEN." + schema: + type: string default: "" - variable: SUDO_PASSWORD label: "SUDO_PASSWORD" + description: "If this optional variable is set, user will have sudo access in the openvscode-server terminal with the specified password." schema: type: string private: true diff --git a/charts/stable/openvscode-server/values.yaml b/charts/stable/openvscode-server/values.yaml index 8cdeaa2acb1..a7d26d1fe73 100644 --- a/charts/stable/openvscode-server/values.yaml +++ b/charts/stable/openvscode-server/values.yaml @@ -3,8 +3,8 @@ image: pullPolicy: IfNotPresent tag: v1.66.0 -portal: - path: "/?tkn={{ .Values.secret.CONNECTION_TOKEN }}" +# portal: + # path: "/?tkn={{ .Values.secret.CONNECTION_TOKEN }}" securityContext: runAsNonRoot: false @@ -14,8 +14,8 @@ podSecurityContext: runAsUser: 0 runAsGroup: 0 -secret: - CONNECTION_TOKEN: "somerandomstring" +secret: {} + # CONNECTION_TOKEN: "somerandomstring" service: main: