From 300e202f279d2d2750199e91cccefcae6ab1aa4a Mon Sep 17 00:00:00 2001 From: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com> Date: Tue, 24 Oct 2023 16:34:14 -0400 Subject: [PATCH] fix(website-shot): Set correct runAsUser (#13710) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Description** As discord and verified by @ZasX it seems to need root privs to run ⚒️ Fixes #13759 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [X] 🪛 Bugfix - [X] ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** **📃 Notes:** **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ] ⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🪞 I have opened a PR on [truecharts/containers](https://github.com/truecharts/containers) adding the container to TrueCharts mirror repo. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com> --- charts/stable/website-shot/Chart.yaml | 4 ++-- charts/stable/website-shot/questions.yaml | 4 ++-- charts/stable/website-shot/values.yaml | 9 +++++++++ 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/charts/stable/website-shot/Chart.yaml b/charts/stable/website-shot/Chart.yaml index b93afa7d0c8..9ffd4d841ba 100644 --- a/charts/stable/website-shot/Chart.yaml +++ b/charts/stable/website-shot/Chart.yaml @@ -3,7 +3,7 @@ appVersion: "latest" dependencies: - name: common repository: https://library-charts.truecharts.org - version: 14.0.9 + version: 14.0.14 description: Generate a full web-page screenshot with our service, that provides rich interface to make any kind of web screenshots online for free with no limits. The simplest way to take a full page screenshot. home: https://truecharts.org/charts/stable/website-shot icon: https://truecharts.org/img/hotlink-ok/chart-icons/website-shot.png @@ -18,7 +18,7 @@ name: website-shot sources: - https://github.com/truecharts/charts/tree/master/charts/stable/website-shot - https://github.com/Flowko/website-shot -version: 6.0.1 +version: 7.0.0 annotations: truecharts.org/catagories: | - media diff --git a/charts/stable/website-shot/questions.yaml b/charts/stable/website-shot/questions.yaml index 21284263f6d..2a911fdd60e 100644 --- a/charts/stable/website-shot/questions.yaml +++ b/charts/stable/website-shot/questions.yaml @@ -66,13 +66,13 @@ questions: description: "The UserID of the user running the application" schema: type: int - default: 568 + default: 1000 - variable: runAsGroup label: "runAsGroup" description: "The groupID this App of the user running the application" schema: type: int - default: 568 + default: 1000 # Include{securityContextContainer} # Include{securityContextAdvanced} # Include{securityContextPod} diff --git a/charts/stable/website-shot/values.yaml b/charts/stable/website-shot/values.yaml index 731d562a933..cd119f5d0e3 100644 --- a/charts/stable/website-shot/values.yaml +++ b/charts/stable/website-shot/values.yaml @@ -2,16 +2,25 @@ image: repository: tccr.io/truecharts/website-shot tag: latest@sha256:47d12e7af8330ae487d07a69500082b7c59182c6d9053a872169456ec337b017 pullPolicy: IfNotPresent + +securityContext: + container: + readOnlyRootFilesystem: false + runAsGroup: 1000 + runAsUser: 1000 + service: main: ports: main: port: 10221 targetPort: 3000 + persistence: screenshots: enabled: true mountPath: "/usr/src/website-shot/screenshots" + portal: open: enabled: true