[DNM] Synapse Matrix Fixes (#2582)

* Attempting to fix issues with synapse that prevent registration using the homeserver.

1. Incorrect references for mail values in _secret.tpl
2. The shared secret question was nested under enable registration, however it's purpose is to bypass normal registration.
3. Coturn shared secret was missing from questions

* Update charts/stable/synapse/questions.yaml

* Update charts/stable/synapse/questions.yaml

* Update charts/stable/synapse/templates/_secret.tpl

* PR #2582 Synapse configuration

Updates according to PR comments

* PR #2582 Synapse configuration

Fix trailing whitespace

* Update charts/stable/synapse/Chart.yaml

* Update Chart.yaml

* Update questions.yaml

Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>

charts/stable/synapse/templates/_configmap.tpl

@@ -14,6 +14,12 @@ data:
     server_name: {{ .Values.matrix.serverName }}
     pid_file: /data/homeserver.pid
     public_baseurl: {{ include "matrix.baseUrl" . | quote }}
+
+    {{- if .Values.matrix.clientBaseURL -}}
+    # Client Base URL, Formerly riot_base_url
+    client_base_url: {{ .Values.matrix.clientBaseURL }}
+    {{- end}}
+
     use_presence: {{ .Values.matrix.presence }}
 
     allow_public_rooms_over_federation: {{ and .Values.matrix.federation.enabled .Values.matrix.federation.allowPublicRooms }}

charts/stable/synapse/templates/_secret.tpl

@@ -31,11 +31,11 @@ stringData:
     email:
       enable_notifs: {{ .Values.mail.enabled }}
       notif_from: {{ .Values.mail.from }}
-      smtp_host: {{ .Values.mail.external.host }}
-      smtp_port: {{ .Values.mail.external.port }}
-      smtp_user: {{ .Values.mail.external.username }}
-      smtp_pass: {{ .Values.mail.external.password }}
-      require_transport_security: {{ .Values.mail.external.requireTransportSecurity }}
+      smtp_host: {{ .Values.mail.host }}
+      smtp_port: {{ .Values.mail.port }}
+      smtp_user: {{ .Values.mail.username }}
+      smtp_pass: {{ .Values.mail.password }}
+      require_transport_security: {{ .Values.mail.requireTransportSecurity }}
     {{- end }}
 
     database:
@@ -50,8 +50,8 @@ stringData:
           cp_max: 10
           sslmode: "disable"
 
-    {{- if .Values.matrix.registration.sharedSecret }}
-    registration_shared_secret: {{ .Values.matrix.registration.sharedSecret }}
+    {{- if .Values.matrix.sharedSecret }}
+    registration_shared_secret: {{ .Values.matrix.sharedSecret }}
     {{- end }}
 
     macaroon_secret_key: {{ $msk }}