From 1bbf1d7214495fb7e67ee00c055974f9703ab717 Mon Sep 17 00:00:00 2001
From: kjeld Schouten-Lebbing <kjeld@schouten-lebbing.nl>
Date: Sun, 15 Aug 2021 13:55:00 +0200
Subject: [PATCH] Don't submit when input is missing

---
 .../Quick-Start Guides/14-linking-apps.md     | 58 ++++++++++---------
 1 file changed, 30 insertions(+), 28 deletions(-)

diff --git a/docs/manual/Quick-Start Guides/14-linking-apps.md b/docs/manual/Quick-Start Guides/14-linking-apps.md
index 79fe4709b57..3d472abee7a 100644
--- a/docs/manual/Quick-Start Guides/14-linking-apps.md	
+++ b/docs/manual/Quick-Start Guides/14-linking-apps.md	
@@ -23,33 +23,7 @@ If you need to reach a different service (which is not often the case!), you nee
 ##### Internal Domain Name generator
 
 
-<SCRIPT LANGUAGE="JavaScript">
-function process (form) {
-    var svcdns = generatesvc(form.name.value, form.app.value, form.service.value);
-    alert ("Service DNS Name: " + svcdns);
-     console.log(svcdns)
-}
-
-
-
-function generatesvc(name, app, service) {
-    var svcname = ""
-    if (name == app) {
-      svcname = name ;
-    } else {
-      svcname = name + "-" + app ;
-    }
-    if (service) {
-      svcname = svcname + "-" + service ;
-    }
-    let svcdns = svcname + "." + "ix-" + name + ".svc.cluster.local" ;
-    return svcdns;
-};
-</SCRIPT>
-
-<link href="https://truecharts.org/_static/form.css" type="text/css" rel="stylesheet" />
-
-<FORM NAME="frameform" ACTION="" METHOD="GET"><BR>
+<FORM id="frameform"><BR>
 <div class="form">
   <div class="subtitle">Generate Internal DNS Name:</div>
   <div class="input-container ic1">
@@ -67,10 +41,38 @@ function generatesvc(name, app, service) {
     <div class="cut cut-short"></div>
     <label for="service" class="placeholder">Service (Optional)</>
   </div>
-  <INPUT TYPE="button" class="submit" NAME="button" Value="Generate" onClick="process(this.form)">
+  <INPUT TYPE="submit" class="submit" NAME="button" Value="Generate">
 </div>
 </FORM>
 
+<SCRIPT LANGUAGE="JavaScript">
+const form = document.getElementById('frameform');
+const name = document.getElementById('name');
+const app = document.getElementById('app');
+const service = document.getElementById('service');
+
+form.onsubmit = submit;
+
+function submit(event) {
+
+
+    var svcname = ""
+    if (name.value == app.value) {
+      svcname = name.value ;
+    } else {
+      svcname = name.value + "-" + app.value ;
+    }
+    if (service.value) {
+      svcname = svcname + "-" + service.value ;
+    }
+    let svcdns = svcname + "." + "ix-" + name.value + ".svc.cluster.local" ;
+    alert ("Service DNS Name: " + svcdns);
+     console.log(svcdns)
+    return false;
+}
+</SCRIPT>
+
+
 
 ##### Example