chore(traefik): BREAKING CHANGE default to 443/80 (#16368)

**Description**
Its time we just use 80/443 on traefik by default.

Technically a breaking change for helm users.
SCALE users shouldn't be affected much.

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [ ] ⚖️ My code follows the style guidelines of this project
- [ ] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [ ] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
This commit is contained in:
Kjeld Schouten
2023-12-23 19:18:47 +01:00
committed by GitHub
parent 712d425846
commit 0cee2cf500
5 changed files with 33 additions and 10 deletions
+1 -1
View File
@@ -1,7 +1,7 @@
kubeVersion: ">=1.24.0-0" kubeVersion: ">=1.24.0-0"
apiVersion: v2 apiVersion: v2
name: traefik name: traefik
version: 23.0.8 version: 24.0.0
appVersion: 2.10.5 appVersion: 2.10.5
description: Traefik is a flexible reverse proxy and Ingress Provider. description: Traefik is a flexible reverse proxy and Ingress Provider.
home: https://truecharts.org/charts/enterprise/traefik home: https://truecharts.org/charts/enterprise/traefik
@@ -0,0 +1,11 @@
# -- Options for the main traefik service, where the entrypoints traffic comes from
# from.
service:
tcp:
ports:
web:
port: 9080
websecure:
port: 9443
+2 -5
View File
@@ -50,11 +50,8 @@ find the Traefik app in the list of apps, and click **Install**
The setup of Traefik is relatively straight-forward. Most of the settings remain unchanged from default, except for these two: The setup of Traefik is relatively straight-forward. Most of the settings remain unchanged from default, except for these two:
- **Application Name**: Enter a name for your app. You may use simply _traefik_ for this field. - **Application Name**: Enter a name for your app. You may use simply _traefik_ for this field.
- **Networking and Services**: Under TCP Services, find and change: - At the bottom, check the warning checkbox.
- **web Entrypoint Configuration** > **Entrypoints port:**
Change port `9080` to port `80`
- **websecure Entrypoint Configuration** > **Entrypoints port:**
Change port `9443` to port `443`
Continue to section 12, and select **Next**. Traefik will now be installed. Continue to section 12, and select **Next**. Traefik will now be installed.
After installation you can access the Traefik dashboard using your host IP address followed by `:9000`, or by simply clicking "Web Portal" on the application's entry under **Apps** > **Installed Applications**. After installation you can access the Traefik dashboard using your host IP address followed by `:9000`, or by simply clicking "Web Portal" on the application's entry under **Apps** > **Installed Applications**.
+17 -2
View File
@@ -247,7 +247,7 @@ questions:
label: "Entrypoints Port" label: "Entrypoints Port"
schema: schema:
type: int type: int
default: 9080 default: 80
required: true required: true
- variable: advanced - variable: advanced
label: Show Advanced Settings label: Show Advanced Settings
@@ -277,7 +277,7 @@ questions:
label: "Entrypoints Port" label: "Entrypoints Port"
schema: schema:
type: int type: int
default: 9443 default: 443
required: true required: true
- variable: advanced - variable: advanced
label: Show Advanced Settings label: Show Advanced Settings
@@ -415,3 +415,18 @@ questions:
# Include{netshoot} # Include{netshoot}
# Include{vpn} # Include{vpn}
# Include{documentation} # Include{documentation}
- variable: warning
group: Documentation
label: 'WARNING: If installed, be sure to move the TrueNAS GUI to another port (not 80 or 443).'
description: 'See: <br /><a href="https://truecharts.org/charts/enterprise/traefik/how-to">https://truecharts.org/charts/enterprise/traefik/how-to</a> for more info.'
schema:
additional_attrs: true
type: dict
attrs:
- variable: warningconfim
label: I am aware that I will brick my system, if I did not follow the instructions.
schema:
type: boolean
default: false
required: true
+2 -2
View File
@@ -180,7 +180,7 @@ service:
ports: ports:
web: web:
enabled: true enabled: true
port: 9080 port: 80
protocol: http protocol: http
redirectTo: websecure redirectTo: websecure
# Options: Empty, 0 (ingore), or positive int # Options: Empty, 0 (ingore), or positive int
@@ -201,7 +201,7 @@ service:
insecureMode: false insecureMode: false
websecure: websecure:
enabled: true enabled: true
port: 9443 port: 443
protocol: https protocol: https
# -- Configure (Forwarded Headers)[https://doc.traefik.io/traefik/routing/entrypoints/#forwarded-headers] Support # -- Configure (Forwarded Headers)[https://doc.traefik.io/traefik/routing/entrypoints/#forwarded-headers] Support
forwardedHeaders: forwardedHeaders: