feat(stable): BREAKING CHANGE migrate to new common part 1 (#7900)

**Description**
Part 1 of the migration to new common on the stable train.
This basically breaks most/all charts requiring a reinstall on SCALE as
well.

Helm users shouldn't need a reinstall but could migrate their
values.yaml modification manually besides backing-up and porting the
databases.

There be Dragons basically, as we obviously cannot 100% go over
each-and-every single app in the stable train like we did in the
enterprise train.

**⚙️ Type of change**

- [x] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
Via CI and manually validation in a lot of cases where the CI did not
correctly check things.
Additional catalog item creation tooling for local testing has been
added as well.

**📃 Notes:**
There will be issues in the future but we should get as much working
well as we can.

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

** App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
This commit is contained in:
Kjeld Schouten-Lebbing
2023-04-11 12:07:17 +02:00
committed by GitHub
parent 14bc83d3c7
commit 0b726419d4
1146 changed files with 15731 additions and 17107 deletions
+2 -3
View File
@@ -3,7 +3,7 @@ appVersion: "3.0.9.1549"
dependencies:
- name: common
repository: https://library-charts.truecharts.org
version: 11.1.2
version: 12.2.32
- condition: postgresql.enabled
name: postgresql
repository: https://charts.truecharts.org/
@@ -26,9 +26,8 @@ sources:
- https://github.com/truecharts/charts/tree/master/charts/stable/sonarr
- https://github.com/Sonarr/Sonarr
type: application
version: 14.0.0
version: 15.0.0
annotations:
truecharts.org/catagories: |
- media
truecharts.org/SCALE-support: "true"
truecharts.org/grade: U
+43 -47
View File
@@ -10,40 +10,36 @@ questions:
# Include{replicas1}
# Include{podSpec}
# Include{containerMain}
- variable: env
group: App Configuration
label: Image Environment
schema:
additional_attrs: true
type: dict
attrs:
- variable: SONARR__AUTHENTICATION_METHOD
label: Auth Method
description: Sets the auth method.
schema:
type: string
default: ""
enum:
- value: ""
description: In-App Setting
- value: External
description: External/None
- value: Basic
description: Basic
- value: Forms
description: Forms
# Include{containerBasic}
# Include{containerAdvanced}
- variable: env
group: App Configuration
label: Image Environment
schema:
additional_attrs: true
type: dict
attrs:
- variable: SONARR__AUTHENTICATION_METHOD
label: Auth Method
description: Sets the auth method.
schema:
type: string
default: ""
enum:
- value: ""
description: In-App Setting
- value: External
description: External/None
- value: Basic
description: Basic
- value: Forms
description: Forms
# Include{containerConfig}
# Include{serviceRoot}
- variable: main
label: Main Service
description: The Primary service on which the healthcheck runs, often the webUI
schema:
additional_attrs: true
type: dict
attrs:
# Include{serviceMain}
# Include{serviceSelectorLoadBalancer}
# Include{serviceSelectorExtras}
- variable: main
@@ -86,27 +82,27 @@ questions:
# Include{ingressList}
# Include{securityContextRoot}
- variable: runAsUser
label: runAsUser
description: The UserID of the user running the application
schema:
type: int
default: 568
- variable: runAsGroup
label: runAsGroup
description: The groupID this App of the user running the application
schema:
type: int
default: 568
- variable: runAsUser
label: "runAsUser"
description: "The UserID of the user running the application"
schema:
type: int
default: 568
- variable: runAsGroup
label: "runAsGroup"
description: "The groupID this App of the user running the application"
schema:
type: int
default: 568
# Include{securityContextContainer}
# Include{securityContextAdvanced}
# Include{securityContextPod}
- variable: fsGroup
label: fsGroup
description: The group that should own ALL storage.
schema:
type: int
default: 568
- variable: fsGroup
label: "fsGroup"
description: "The group that should own ALL storage."
schema:
type: int
default: 568
# Include{resources}
# Include{advanced}
+1
View File
@@ -0,0 +1 @@
{{- include "tc.v1.common.lib.chart.notes" $ -}}
+2 -2
View File
@@ -1,6 +1,6 @@
{{/* Make sure all variables are set properly */}}
{{- include "tc.common.loader.init" . }}
{{- include "tc.v1.common.loader.init" . }}
{{/* Render the templates */}}
{{ include "tc.common.loader.apply" . }}
{{ include "tc.v1.common.loader.apply" . }}
+47 -46
View File
@@ -2,61 +2,62 @@ image:
repository: tccr.io/truecharts/sonarr
pullPolicy: IfNotPresent
tag: 3.0.9.1549@sha256:294b6288d91346f6e65f8cb344b42d17c97b3ee7ada501d77307088f79a8dc15
env:
SONARR__PORT: "{{ .Values.service.main.ports.main.port }}"
SONARR__AUTHENTICATION_METHOD: ""
# Enable postgres if v4 of sonarr supports it.
# SONARR__POSTGRES_PORT: 5432
# SONARR__POSTGRES_USER: "{{ .Values.postgresql.postgresqlUsername }}"
# SONARR__POSTGRES_MAIN_DB: "{{ .Values.postgresql.postgresqlDatabase }}"
# SONARR__POSTGRES_HOST:
# secretKeyRef:
# name: dbcreds
# key: plainhost
# SONARR__POSTGRES_PASSWORD:
# secretKeyRef:
# name: dbcreds
# key: postgresql-password
service:
main:
ports:
main:
port: 8989
probes:
liveness:
enabled: true
## Set this to true if you wish to specify your own livenessProbe
custom: true
## The spec field contains the values for the default livenessProbe.
## If you selected custom: true, this field holds the definition of the livenessProbe.
spec:
exec:
command:
- /usr/bin/env
- bash
- -c
- curl --fail localhost:8989/api/v3/system/status?apiKey=`IFS=\> && while
read -d \< E C; do if [[ $E = "ApiKey" ]]; then echo $C; fi; done < /config/config.xml`
failureThreshold: 5
initialDelaySeconds: 60
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 10
persistence:
config:
enabled: true
mountPath: /config
# might be supported on sonarr v4 upon released
postgresql:
enabled: false
existingSecret: dbcreds
postgresqlDatabase: sonarr
postgresqlUsername: sonarr
cnpg:
main:
enabled: false
database: sonarr
user: sonarr
portal:
enabled: true
open:
enabled: true
workload:
main:
podSpec:
containers:
main:
probes:
liveness:
enabled: true
## Set this to true if you wish to specify your own livenessProbe
custom: true
## The spec field contains the values for the default livenessProbe.
## If you selected custom: true, this field holds the definition of the livenessProbe.
spec:
exec:
command:
- /usr/bin/env
- bash
- -c
- curl --fail localhost:8989/api/v3/system/status?apiKey=`IFS=\> && while read -d \< E C; do if [[ $E = "ApiKey" ]]; then echo $C; fi; done < /config/config.xml`
failureThreshold: 5
initialDelaySeconds: 60
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 10
env:
SONARR__PORT: "{{ .Values.service.main.ports.main.port }}"
SONARR__AUTHENTICATION_METHOD: ""
# Enable postgres if v4 of sonarr supports it.
# SONARR__POSTGRES_PORT: 5432
# SONARR__POSTGRES_USER: "{{ .Values.cnpg.main.user }}"
# SONARR__POSTGRES_MAIN_DB: "{{ .Values.cnpg.main.database }}"
# SONARR__POSTGRES_HOST:
# secretKeyRef:
# name: cnpg-main-urls
# key: host
# SONARR__POSTGRES_PASSWORD:
# secretKeyRef:
# name: cnpg-main-urls
# key: password