feat(stable): BREAKING CHANGE migrate to new common part 1 (#7900)

**Description**
Part 1 of the migration to new common on the stable train.
This basically breaks most/all charts requiring a reinstall on SCALE as
well.

Helm users shouldn't need a reinstall but could migrate their
values.yaml modification manually besides backing-up and porting the
databases.

There be Dragons basically, as we obviously cannot 100% go over
each-and-every single app in the stable train like we did in the
enterprise train.

**⚙️ Type of change**

- [x] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [x] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
Via CI and manually validation in a lot of cases where the CI did not
correctly check things.
Additional catalog item creation tooling for local testing has been
added as well.

**📃 Notes:**
There will be issues in the future but we should get as much working
well as we can.

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

charts/stable/rdesktop/Chart.yaml

@@ -3,7 +3,7 @@ appVersion: "latest"
 dependencies:
   - name: common
     repository: https://library-charts.truecharts.org
-    version: 11.1.2
+    version: 12.2.32
 deprecated: false
 description: Full desktop environments in many popular flavors for Alpine, Ubuntu, Arch, and Fedora accessible via RDP.
 home: https://truecharts.org/charts/stable/rdesktop
@@ -23,9 +23,8 @@ sources:
   - https://github.com/orgs/linuxserver/packages/container/package/rdesktop
   - https://github.com/linuxserver/docker-rdesktop#readme
 type: application
-version: 3.0.22
+version: 4.0.0
 annotations:
   truecharts.org/catagories: |
     - desktops
   truecharts.org/SCALE-support: "true"
-  truecharts.org/grade: U

charts/stable/rdesktop/questions.yaml

@@ -71,18 +71,14 @@ questions:
 # Include{replicas1}
 # Include{podSpec}
 # Include{containerMain}
+
+
 # Include{containerBasic}
 # Include{containerAdvanced}
 
 # Include{containerConfig}
 # Include{serviceRoot}
-        - variable: main
-          label: "Main Service"
-          description: "The Primary service on which the healthcheck runs, often the webUI"
-          schema:
-            additional_attrs: true
-            type: dict
-            attrs:
+# Include{serviceMain}
 # Include{serviceSelectorLoadBalancer}
 # Include{serviceSelectorExtras}
                     - variable: main
@@ -140,7 +136,7 @@ questions:
 # Include{securityContextContainer}
 # Include{securityContextAdvanced}
 # Include{securityContextPod}
-             - variable: fsGroup
+              - variable: fsGroup
                 label: "fsGroup"
                 description: "The group that should own ALL storage."
                 schema:

charts/stable/rdesktop/templates/NOTES.txt

@@ -0,0 +1 @@
+{{- include "tc.v1.common.lib.chart.notes" $ -}}

charts/stable/rdesktop/templates/common.yaml

@@ -1,2 +1,2 @@
 {{/* Render the templates */}}
-{{ include "tc.common.loader.all" . }}
+{{ include "tc.v1.common.loader.all" . }}

charts/stable/rdesktop/values.yaml

@@ -14,7 +14,6 @@ archXFCEImage:
   repository: tccr.io/truecharts/rdesktop-arch-xfce
   tag: latest@sha256:b2195dd2411d0a96422d36ac4cff070efdb257d3dca42d3fe80064553afd4731
   pullPolicy: Always
-
 alpineKDEImage:
   repository: tccr.io/truecharts/rdesktop-alpine-kde
   tag: latest@sha256:dbb1dc0621103bf695fd877befd0e56d414b99757e3a9d6b1e505ab3bc9e50b9
@@ -31,7 +30,6 @@ archKDEImage:
   repository: tccr.io/truecharts/rdesktop-arch-kde
   tag: latest@sha256:6119ad975f98a7429b2b58dc9c21327b237420fd5d05f4dd411ddc18c34a4e2e
   pullPolicy: Always
-
 alpineMATEImage:
   repository: tccr.io/truecharts/rdesktop-alpine-mate
   tag: latest@sha256:22817b0f9472b933e0437978ef939f76e4e577577103bad9aa009773f578122a
@@ -48,7 +46,6 @@ archMATEImage:
   repository: tccr.io/truecharts/rdesktop-arch-mate
   tag: latest@sha256:54ee98d02eadbf84f472d6cadaf04744fd14e26a50144747ef505cc2337702a3
   pullPolicy: Always
-
 alpineI3Image:
   repository: tccr.io/truecharts/rdesktop-alpine-i3
   tag: latest@sha256:82f3293f7c1428d8fe4c7d3506f0caf765d3c75dc59518b9b7723eb2b7fee399
@@ -65,7 +62,6 @@ archI3Image:
   repository: tccr.io/truecharts/rdesktop-arch-i3
   tag: latest@sha256:fa797dcb633ec86f83518182763865150e1c7bb4275aae59c984c33eedba5d95
   pullPolicy: Always
-
 alpineOpenBoxImage:
   repository: tccr.io/truecharts/rdesktop-alpine-openbox
   tag: latest@sha256:424befd21ded014d18448ca8490457a395fc21c44545ffe81f5bc40da7a51804
@@ -82,7 +78,6 @@ archOpenBoxImage:
   repository: tccr.io/truecharts/rdesktop-arch-openbox
   tag: latest@sha256:80b057016ed3b6afacda3d96295a8b29c86c8fc40b69445cc018b17969645469
   pullPolicy: Always
-
 alpineICEWMImage:
   repository: tccr.io/truecharts/rdesktop-alpine-icewm
   tag: latest@sha256:3cc2fd8ee3bc18e7ebc5720fe6b5d47d8fdd3d6bc239add1cc0a17260d5f7556
@@ -99,29 +94,24 @@ archICEWMImage:
   repository: tccr.io/truecharts/rdesktop-arch-icewm
   tag: latest@sha256:e7c1e505662d3485d09bdde575df0ea150ae3893c8c3816390d157f5853612d1
   pullPolicy: Always
-
 imageSelector: image
-
-podSecurityContext:
-  runAsGroup: 0
-  runAsUser: 0
-
-securityContext:
-  readOnlyRootFilesystem: false
-  runAsNonRoot: false
-
 service:
   main:
     ports:
       main:
         port: 3389
-        protocol: HTTP
+        protocol: http
         targetPort: 3389
-
 persistence:
   config:
     enabled: true
     mountPath: /config
-
 portal:
-  enabled: true
+  open:
+    enabled: true
+securityContext:
+  container:
+    readOnlyRootFilesystem: false
+    runAsNonRoot: false
+    runAsGroup: 0
+    runAsUser: 0