From 082f772c1ed7d7594bc4038a566ca768170a9617 Mon Sep 17 00:00:00 2001
From: Malar Kannan <malarkannan.invention@gmail.com>
Date: Sun, 29 Dec 2024 19:23:53 +0530
Subject: [PATCH] fix(authelia): authelia configuration.yaml configmap for
 public client secret should be empty string (#29496)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
See
https://www.authelia.com/configuration/identity-providers/openid-connect/clients/#client_secret
for explanation
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->
This would fix support for oidc auth with authelia for dashy chart

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [x] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
- [x] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):` or `chore(chart-name):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._

---------

Signed-off-by: Malar Kannan <malarkannan.invention@gmail.com>
Signed-off-by: Kjeld Schouten <info@kjeldschouten.nl>
Co-authored-by: Kjeld Schouten <info@kjeldschouten.nl>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
---
 charts/premium/authelia/Chart.yaml               | 2 +-
 charts/premium/authelia/templates/_configmap.tpl | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/charts/premium/authelia/Chart.yaml b/charts/premium/authelia/Chart.yaml
index 17b5504ff39..00fe287a8dc 100644
--- a/charts/premium/authelia/Chart.yaml
+++ b/charts/premium/authelia/Chart.yaml
@@ -50,4 +50,4 @@ sources:
   - https://github.com/authelia/chartrepo
   - https://github.com/truecharts/charts/tree/master/charts/premium/authelia
 type: application
-version: 25.7.0
+version: 26.0.0
diff --git a/charts/premium/authelia/templates/_configmap.tpl b/charts/premium/authelia/templates/_configmap.tpl
index 6c2c0c99e25..7cdce1be9c3 100644
--- a/charts/premium/authelia/templates/_configmap.tpl
+++ b/charts/premium/authelia/templates/_configmap.tpl
@@ -245,9 +245,11 @@ data:
     {{- range $client := .Values.identity_providers.oidc.clients }}
         - id: {{ $client.id }}
           description: {{ $client.description | default $client.id }}
-          secret: {{ $client.secret | default (randAlphaNum 128) }}
           {{- if $client.public }}
           public: {{ $client.public }}
+          secret: ""
+          {{- else }}
+          secret: {{ $client.secret | required "Client secret is required" }}
           {{- end }}
           authorization_policy: {{ $client.authorization_policy | default "two_factor" }}
           consent_mode: {{ $client.consent_mode | default "auto" }}