From 0451e0887b8bfce8ee5c45ac6b490b230265d2a0 Mon Sep 17 00:00:00 2001
From: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com>
Date: Fri, 25 Aug 2023 04:19:36 -0400
Subject: [PATCH] fix(modsecurity-crs) remove backend variable. (#11791)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Description**
Remove the backend option as it not needed for the app in use of the
traefik plugin.
Added docs.
⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [ ] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [X ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X ] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [X] 📄 I have made corresponding changes to the documentation
- [ ] ⚠️ My changes generate no new warnings
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [X] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
---
 charts/stable/modsecurity-crs/Chart.yaml            |  2 +-
 .../modsecurity-crs/docs/installation_notes.md      | 11 +++++++++++
 charts/stable/modsecurity-crs/questions.yaml        | 13 -------------
 charts/stable/modsecurity-crs/values.yaml           |  1 -
 4 files changed, 12 insertions(+), 15 deletions(-)
 create mode 100644 charts/stable/modsecurity-crs/docs/installation_notes.md

diff --git a/charts/stable/modsecurity-crs/Chart.yaml b/charts/stable/modsecurity-crs/Chart.yaml
index 8a7d1b36d2b..dac17c1a2c8 100644
--- a/charts/stable/modsecurity-crs/Chart.yaml
+++ b/charts/stable/modsecurity-crs/Chart.yaml
@@ -22,7 +22,7 @@ sources:
   - https://github.com/truecharts/charts/tree/master/charts/stable/modsecurity-crs
   - https://github.com/coreruleset/modsecurity-crs-docker
 type: application
-version: 0.0.1
+version: 0.0.2
 annotations:
   truecharts.org/catagories: |
     - networking
diff --git a/charts/stable/modsecurity-crs/docs/installation_notes.md b/charts/stable/modsecurity-crs/docs/installation_notes.md
new file mode 100644
index 00000000000..d55b470b613
--- /dev/null
+++ b/charts/stable/modsecurity-crs/docs/installation_notes.md
@@ -0,0 +1,11 @@
+# Installation Notes
+
+To use this to protect multiple apps setup the traefik middleware "modsecurity".
+
+- Name
+- ModSecurity Url
+- timeout Millis
+- maxBody Size
+
+If you do not plan to use traefik or only want to protect a single app, just add a custom variable "BACKEND" in Extra Environment Variables.
+The value can be <http://ip:port> or <http://$NAME.ix-$NAME.svc.cluster.local:PORT>.
diff --git a/charts/stable/modsecurity-crs/questions.yaml b/charts/stable/modsecurity-crs/questions.yaml
index e51d7a80037..9b037cb5fc6 100644
--- a/charts/stable/modsecurity-crs/questions.yaml
+++ b/charts/stable/modsecurity-crs/questions.yaml
@@ -11,19 +11,6 @@ questions:
 # Include{podSpec}
 # Include{containerMain}
 
-                                - variable: env
-                                  label: Image Environment
-                                  schema:
-                                    additional_attrs: true
-                                    type: dict
-                                    attrs:
-                                      - variable: BACKEND
-                                        label: Backend
-                                        description: A string indicating the partial URL for the remote server of the ProxyPass directive.
-                                        schema:
-                                          type: string
-                                          private: true
-                                          default: ""
 # Include{containerBasic}
 # Include{containerAdvanced}
 
diff --git a/charts/stable/modsecurity-crs/values.yaml b/charts/stable/modsecurity-crs/values.yaml
index ebd460133a7..af204bc4308 100644
--- a/charts/stable/modsecurity-crs/values.yaml
+++ b/charts/stable/modsecurity-crs/values.yaml
@@ -34,7 +34,6 @@ workload:
             MODSEC_DATA_DIR: "{{ .Values.persistence.data.mountPath }}"
             MODSEC_TMP_DIR: "{{ .Values.persistence.temp.mountPath }}"
             MODSEC_UPLOAD_DIR: "{{ .Values.persistence.upload.mountPath }}"
-            BACKEND: "http://localhost:80"
 
 persistence:
   data: