From 9cfa07ba1c8d64e1201461595a3592c65cfdcd4d Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 16 Nov 2026 18:28:19 -0500 Subject: [PATCH] G6: bump 8 roles for ansible-lint CI callers; document rollout Bumps debian, libvirt-guest, ingress-nginx, grafana, nextcloud, minio, tor-controller and mediawiki to commits that add only a manual-only lint caller, a lint baseline and (tor-controller, mediawiki) a fixed role name in tests/test.yml. Nothing these roles deploy changes. adding-ci.md: rollout table, test results, and a note not to baseline syntax-check findings. Refs DevOps/software-infrastructure#54 Co-Authored-By: Claude Opus 5.5 --- docs/ci-cd/adding-ci.md | 23 +++++++++++++++++++++-- roles/ericomeehan.debian | 2 +- roles/ericomeehan.grafana | 2 +- roles/ericomeehan.ingress-nginx | 2 +- roles/ericomeehan.libvirt-guest | 2 +- roles/ericomeehan.mediawiki | 2 +- roles/ericomeehan.minio | 2 +- roles/ericomeehan.nextcloud | 2 +- roles/ericomeehan.tor-controller | 2 +- 9 files changed, 29 insertions(+), 10 deletions(-) diff --git a/docs/ci-cd/adding-ci.md b/docs/ci-cd/adding-ci.md index 43b19ef..aba9e76 100644 --- a/docs/ci-cd/adding-ci.md +++ b/docs/ci-cd/adding-ci.md @@ -54,8 +54,8 @@ jobs: How it works and why: - ansible-lint reads a role's name from its directory, so the job lints a copy named like the playbooks name it. The repo's own name also resolves, because - galaxy's skeleton `tests/test.yml` uses it and `syntax-check` can't be - skipped. + galaxy's skeleton `tests/test.yml` uses it, and that playbook should be + syntax-checked rather than baselined (below). - `role-name` is a warning, not a failure. Our roles keep galaxy's skeleton `meta/main.yml` and are called `ericomeehan.`, which galaxy's naming rule rejects. @@ -87,6 +87,23 @@ Shrink the baseline as files are cleaned up, so it covers less over time. `.gitea/` is excluded: workflow files are checked by actionlint, not ansible-lint. +**Don't baseline `syntax-check[*]`.** `--generate-ignore` will write it, but +an ignored syntax check means that playbook is never parsed. Skeleton +`tests/test.yml` files sometimes name a role that doesn't exist (a copy-paste +from another role); fix the name to the repo's name instead. G6 did this for +tor-controller and mediawiki. dex's `playbooks/deploy-eom.yml` is still +baselined this way (see #53). + +**Rolled out, manual-only until S8 and G1:** + +| Batch | Roles | +|---|---| +| G5 (#53) | gitea, www, dex, eom, discourse, mcp-servers, listmonk, prometheus | +| G6 (#54) batch 1 | debian, libvirt-guest, ingress-nginx, grafana, nextcloud, minio, tor-controller, mediawiki | + +Not rolled out yet: see #54 for the remaining list and the roles that need a +decision first. + ### Helm chart ```yaml @@ -170,6 +187,8 @@ a local build of the tools image (1.0.0), against: | role lint (2026-11-16, G5 batch 2) | eom, discourse, mcp-servers, listmonk, prometheus with generated baselines, and gitea, www, dex again | all pass | | | listmonk plus a new `tasks/extra.yml` with an unnamed `shell:` | fails on the new file | | | eom with the previous step (no bare-name link) | fails: `tests/test.yml` names the role `eom` | +| role lint (2026-11-16, G6 batch 1) | debian, libvirt-guest, ingress-nginx, grafana, nextcloud, minio, tor-controller, mediawiki with generated baselines | all pass | +| | each of them plus a new `tasks/ci_plant.yml` with an unnamed `shell:` | all fail, on the new file | | helm-lint | DevOps/helm-jamulus | passes | | | a template referencing a missing value | fails in `helm lint` | | | a Service with a string port | fails in kubeconform | diff --git a/roles/ericomeehan.debian b/roles/ericomeehan.debian index 6ca6f56..846aaad 160000 --- a/roles/ericomeehan.debian +++ b/roles/ericomeehan.debian @@ -1 +1 @@ -Subproject commit 6ca6f56cfda0bd58b7d124dcae270259b14db608 +Subproject commit 846aaad3769d87b4724083971c607bccfbf8d92e diff --git a/roles/ericomeehan.grafana b/roles/ericomeehan.grafana index 51a69f1..6fdc683 160000 --- a/roles/ericomeehan.grafana +++ b/roles/ericomeehan.grafana @@ -1 +1 @@ -Subproject commit 51a69f1e62a7de8bdbc10d582aa8a591146cc0fe +Subproject commit 6fdc683f78f92581dcc5780256879758b46cf5bb diff --git a/roles/ericomeehan.ingress-nginx b/roles/ericomeehan.ingress-nginx index 7974d2b..2f3159d 160000 --- a/roles/ericomeehan.ingress-nginx +++ b/roles/ericomeehan.ingress-nginx @@ -1 +1 @@ -Subproject commit 7974d2bad8ce056396159b598ba8943a72c14880 +Subproject commit 2f3159d3894dbde156f4b2ab1735d54621cdd2f4 diff --git a/roles/ericomeehan.libvirt-guest b/roles/ericomeehan.libvirt-guest index 41ebaf6..bb519f1 160000 --- a/roles/ericomeehan.libvirt-guest +++ b/roles/ericomeehan.libvirt-guest @@ -1 +1 @@ -Subproject commit 41ebaf6c539efc303d22daffa1a48f857109c0d8 +Subproject commit bb519f1d0a2c1e2f3b1ec4b96436f14c59dda4d2 diff --git a/roles/ericomeehan.mediawiki b/roles/ericomeehan.mediawiki index acdacca..65e57f4 160000 --- a/roles/ericomeehan.mediawiki +++ b/roles/ericomeehan.mediawiki @@ -1 +1 @@ -Subproject commit acdacca800ade6cd0770c34677c4c4315fd01121 +Subproject commit 65e57f479c5492535da7efa4fa334ecf71955459 diff --git a/roles/ericomeehan.minio b/roles/ericomeehan.minio index d0bc575..6fd1c58 160000 --- a/roles/ericomeehan.minio +++ b/roles/ericomeehan.minio @@ -1 +1 @@ -Subproject commit d0bc5757b424e7911aff49b34eb616bd9e89f955 +Subproject commit 6fd1c58d1c05f9739e05311e1096be3b3eb0ad78 diff --git a/roles/ericomeehan.nextcloud b/roles/ericomeehan.nextcloud index f440a4f..df600bd 160000 --- a/roles/ericomeehan.nextcloud +++ b/roles/ericomeehan.nextcloud @@ -1 +1 @@ -Subproject commit f440a4f464b5c5c09fbe7019af62385a59494d79 +Subproject commit df600bd3ae71b4188dcba0e4fba2e097a57dcba5 diff --git a/roles/ericomeehan.tor-controller b/roles/ericomeehan.tor-controller index 332433b..2cdf6ff 160000 --- a/roles/ericomeehan.tor-controller +++ b/roles/ericomeehan.tor-controller @@ -1 +1 @@ -Subproject commit 332433bd1e22a070ab9dce4e3be5c35693b52315 +Subproject commit 2cdf6ff9c5f34abe05214c5a4bcea86e1e20a18e