From 7a16c2659b22db704a2ea9c99d18d630f6022dc2 Mon Sep 17 00:00:00 2001
From: jessebot <jessebot@linux.com>
Date: Thu, 23 Jan 2025 21:45:37 +0100
Subject: [PATCH] always template out app_domain

---
 README.md                                         | 1 +
 charts/pixelfed/templates/configmap_env.yaml      | 4 +---
 charts/pixelfed/test-values/postgresql-plain.yaml | 2 ++
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 10a8300..2ecd0af 100644
--- a/README.md
+++ b/README.md
@@ -25,6 +25,7 @@ Uses @mattlqx's [docker image](https://ghcr.io/mattlqx/docker-pixelfed) which is
 helm repo add pixelfed https://small-hack.github.io/pixelfed-chart
 
 # download the values.yaml and edit it with your own values such as YOUR hostname
+# especially important is pixelfed.app.domain
 helm show values pixelfed/pixelfed > values.yaml
 
 # install the chart
diff --git a/charts/pixelfed/templates/configmap_env.yaml b/charts/pixelfed/templates/configmap_env.yaml
index 833ea80..e169d72 100644
--- a/charts/pixelfed/templates/configmap_env.yaml
+++ b/charts/pixelfed/templates/configmap_env.yaml
@@ -10,9 +10,7 @@ data:
   APP_PORT: {{ .Values.service.targetPort | quote}}
   APP_URL: {{ .Values.pixelfed.app.url }}
   APP_LOCALE: {{ .Values.pixelfed.app.locale }}
-  {{- with .Values.pixelfed.app.domain }}
-  APP_DOMAIN: {{ . }}
-  {{- end }}
+  APP_DOMAIN: {{ .Values.pixelfed.app.domain | required ".Values.pixelfed.app.domain is required" }}
 
   {{- with .Values.pixelfed.exp_loops }}
   EXP_LOOPS: {{ . }}
diff --git a/charts/pixelfed/test-values/postgresql-plain.yaml b/charts/pixelfed/test-values/postgresql-plain.yaml
index 861b9ea..cac6564 100644
--- a/charts/pixelfed/test-values/postgresql-plain.yaml
+++ b/charts/pixelfed/test-values/postgresql-plain.yaml
@@ -2,6 +2,8 @@
 # it uses postgresql and valkey and provides credentials for them as well as mail
 
 pixelfed:
+  app:
+    domain: "example.com"
   mail:
     username: test
     password: testing1234567